feat(lockfile): track JSR and npm dependencies in config file #22004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 21, 2024
dsherret
commented
Jan 21, 2024
| "http://localhost:4545/subdir/mt_text_typescript.t1.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18", | ||
| "http://localhost:4545/subdir/mt_video_mp2t.t3.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18", | ||
| "http://localhost:4545/subdir/mt_video_vdn.t2.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18" | ||
| "version": "3", |
There was a problem hiding this comment.
This got updated to v3 during my development and I think it's fine to just leave this as v3 now.
dsherret
commented
Jan 21, 2024
cli/tests/integration/run_tests.rs
Outdated
There was a problem hiding this comment.
It would be nice to have a workspace integration test here, but atm workspace support is not very good. I opened #22020 and mentioned to add a test for this when doing that. (there are tests for workspaces in deno_lockfile)
|
Discussed with @marvinhagemeister, this is overall improvement so we're gonna land is as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See overview in denoland/deno_lockfile#13