Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/http): remoteAddress and remotePort not being set #21998

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fix(node/http): remoteAddress and remotePort not being set #21998

merged 3 commits into from
Jan 19, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Ultimately, it came down to using incorrect property names in the FakeSocket constructor. The values are passed under remoteAddress, not hostname and remotePort instead of port.

Fixes #21980

@marvinhagemeister marvinhagemeister merged commit 59f419b into main Jan 19, 2024
14 checks passed
@marvinhagemeister marvinhagemeister deleted the node-http-address branch January 19, 2024 12:09
@satyarohith satyarohith mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request ip is undefined
2 participants
@marvinhagemeister @bartlomieju