Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): send "deno/didChangeDenoConfiguration" on init #21965

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

nayeemrmn
Copy link
Collaborator

So the client can be aware of all active deno.json files without walking the workspace. This changes the interface of the notification parameter, but it's not read in the extension.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 2141543 into denoland:main Jan 17, 2024
14 checks passed
@nayeemrmn nayeemrmn deleted the lsp-deno-config-change-notif-init branch January 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants