Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add exit code for deno info ci #21952

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Conversation

muddlebee
Copy link
Contributor

@muddlebee muddlebee commented Jan 15, 2024

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

@muddlebee muddlebee marked this pull request as ready for review January 15, 2024 21:29
@muddlebee
Copy link
Contributor Author

can anyone trigger the cargo test ci 👀
locally its not running, but I added the ci message in commit 🤔

@bartlomieju
Copy link
Member

can anyone trigger the cargo test ci 👀 locally its not running, but I added the ci message in commit 🤔

This doesn't trigger CI for first-time contributors. I started CI for you.

@muddlebee
Copy link
Contributor Author

@bartlomieju thank you. can you review if its all okay? 👀
ci is passing I see

@bartlomieju bartlomieju added this to the 1.40 milestone Jan 23, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartlomieju bartlomieju enabled auto-merge (squash) January 23, 2024 01:21
@bartlomieju bartlomieju merged commit 7067527 into denoland:main Jan 23, 2024
14 checks passed
@muddlebee muddlebee deleted the deno-info branch January 23, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants