Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/webgpu): surface alpha modes as per spec #21721

Closed
wants to merge 2 commits into from
Closed

fix(ext/webgpu): surface alpha modes as per spec #21721

wants to merge 2 commits into from

Conversation

littledivy
Copy link
Member

https://gpuweb.github.io/gpuweb/#gpucanvasalphamode

Changes:

  • premultiplied instead of preMultipled.
  • Removes extra postMultipled and inherit variants.

@littledivy littledivy requested a review from crowlKats December 28, 2023 04:36
@crowlKats
Copy link
Member

crowlKats commented Dec 28, 2023 •
edited
Loading

would probably better to have wgpu deserialize correctly instead

@littledivy
Copy link
Member Author

what about the extra variants though? I assume it would be breaking change to remove the non-spec variants in wgpu

@crowlKats
Copy link
Member

its fine to keep the extra variants, since the webidl would catch it.

@littledivy
Copy link
Member Author

Ok, will a open a PR in wgpu

@littledivy littledivy closed this Dec 28, 2023
@littledivy littledivy deleted the fix_surface_configure_alphamode branch December 28, 2023 05:22
@littledivy
Copy link
Member Author

gfx-rs/wgpu#4940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @crowlKats