Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime): log deprecated message on first usage of window global #19319

Closed
wants to merge 5 commits into from
Closed

feat(runtime): log deprecated message on first usage of window global #19319

wants to merge 5 commits into from

Conversation

dsherret
Copy link
Member

Part of #13367

@dsherret dsherret marked this pull request as ready for review May 30, 2023 18:35
mmastrac
mmastrac approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret added this to the 1.35 milestone May 30, 2023
lucacasonato
lucacasonato reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before doing this, we should add a deno_lint warning

@dsherret
Copy link
Member Author

dsherret commented Jun 5, 2023

@lucacasonato there has been a no-window-prefix lint rule for quite some time: https://lint.deno.land/?q=no-window-prefix#no-window-prefix

@dsherret
Copy link
Member Author

dsherret commented Jun 5, 2023 •
edited
Loading

Oh, looks like we should make it more strict:

// `alert` is allowed to call with `window` because it's not supported in Workers
window.alert("🍣");

Opened denoland/deno_lint#1163

@dsherret dsherret mentioned this pull request Jun 5, 2023
Closed
@bartlomieju bartlomieju removed this from the 1.35 milestone Jul 3, 2023
petamoriken
petamoriken reviewed Jul 11, 2023
View reviewed changes
runtime/js/98_global_scope.js
Comment on lines +6 to +8
ArraySplit,
ObjectDefineProperties,
StringSlice,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ArrayPrototypeSplit and StringPrototypeSlice are collect.

@dsherret
Copy link
Member Author

This is stale, so going to close.

@dsherret dsherret closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@petamoriken petamoriken petamoriken left review comments

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsherret @mmastrac @petamoriken @lucacasonato @bartlomieju