Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(unstable): remove WebGPU #18094

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Mar 9, 2023

This PR temporarily removes WebGPU (which has behind the --unstable flag in Deno), due to performance complications due to its presence.
It will be brought back in the future; as a point of reference, Chrome will ship WebGPU to stable on 26/04/2023.

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	ext/webgpu/01_webgpu.js
#	ext/webgpu/02_idl_types.js
#	ext/webgpu/03_surface.js
#	ext/webgpu/04_surface_idl_types.js
#	ext/webgpu/Cargo.toml
#	ext/webgpu/lib.rs
#	ext/webgpu/surface.rs
#	runtime/js/98_global_scope.js
#	tools/wgpu_sync.js
@dsherret dsherret changed the title BREAKING: remove WebGPU BREAKING(unstable): remove WebGPU Mar 9, 2023
bartlomieju added a commit that referenced this pull request Mar 16, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For folks that will see this PR: this is a deliberate decision on our side to remove this API at this point. We asked you in the recent survey if you found this API useful and a vast majority of you said that it's not. Having WebGPU incurs 2ms startup time on every user even if you never use it. We will revisit relanding this API in the next few months, in the meantime we plan to open PRs to Rust compiler that would allows us to use weak linking to not incur the startup time performance on users who do not need WebGPU.

@bartlomieju bartlomieju merged commit 35196ea into denoland:main Mar 16, 2023
@comunidadio
Copy link

comunidadio commented Mar 23, 2023

Thanks for the info @bartlomieju.
Looks like removing WebGPU also shaves from 1MB to 4MB off the binary size, depending on the platform.

@andykais
Copy link

andykais commented Apr 7, 2023

@bartlomieju are there are any upstream rust compiler issues/prs that we can use to track the state of webgpu support? Alternatively could we open a issue in deno to track future support for webgpu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants