-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(unstable): remove WebGPU #18094
Conversation
# Conflicts: # Cargo.lock # Cargo.toml # ext/webgpu/01_webgpu.js # ext/webgpu/02_idl_types.js # ext/webgpu/03_surface.js # ext/webgpu/04_surface_idl_types.js # ext/webgpu/Cargo.toml # ext/webgpu/lib.rs # ext/webgpu/surface.rs # runtime/js/98_global_scope.js # tools/wgpu_sync.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For folks that will see this PR: this is a deliberate decision on our side to remove this API at this point. We asked you in the recent survey if you found this API useful and a vast majority of you said that it's not. Having WebGPU incurs 2ms startup time on every user even if you never use it. We will revisit relanding this API in the next few months, in the meantime we plan to open PRs to Rust compiler that would allows us to use weak linking to not incur the startup time performance on users who do not need WebGPU.
Thanks for the info @bartlomieju. |
@bartlomieju are there are any upstream rust compiler issues/prs that we can use to track the state of webgpu support? Alternatively could we open a issue in deno to track future support for webgpu? |
This PR temporarily removes WebGPU (which has behind the
--unstable
flag in Deno), due to performance complications due to its presence.It will be brought back in the future; as a point of reference, Chrome will ship WebGPU to stable on 26/04/2023.