Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): fix importKey error when leading zeroes #16009

Merged
merged 8 commits into from
Oct 3, 2022
Merged

fix(ext/crypto): fix importKey error when leading zeroes #16009

merged 8 commits into from
Oct 3, 2022

Conversation

liruifengv
Copy link
Contributor

fix #15126

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cjihrig
cjihrig reviewed Sep 23, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing in the linting job. Can you run ./tools/format.js and ./tools/lint.js locally and commit the changes.

ext/crypto/import_key.rs Outdated Show resolved Hide resolved
@liruifengv liruifengv requested a review from cjihrig September 24, 2022 04:51
CGQAQ
CGQAQ suggested changes Sep 24, 2022
View reviewed changes
ext/crypto/import_key.rs Outdated Show resolved Hide resolved
ext/crypto/import_key.rs Outdated Show resolved Hide resolved
ext/crypto/import_key.rs Outdated Show resolved Hide resolved
cjihrig
cjihrig approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thoughts @littledivy?

littledivy
littledivy approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit b3444e0 into denoland:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGQAQ CGQAQ CGQAQ requested changes

@littledivy littledivy littledivy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: WebCryptoAPI JWK key export/import roundtrip doesn't always work
5 participants
@liruifengv @CLAassistant @cjihrig @CGQAQ @littledivy