fix(serde_v8): Implement MapAccess for StructAccess #15962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suficio
force-pushed
the
deserialize-struct
branch
from
d9abc55 to
138bdd9
Compare
bartlomieju
approved these changes
Oct 2, 2022
There was a problem hiding this comment.
LGTM, nice work @Suficio! I verified that added tests fail on main branch.
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
`StructAccess` implements` serde::de::SeqAccess` instead of `serde::de::MapAccess` thus interpreting structs as sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructAccessimplementsserde::de::SeqAccessinstead ofserde::de::MapAccessthus interpreting structs as sequences.Closes #15920