-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handler always reads error.stack, regardless of type (and blows up) #935
Comments
For comparision, this is what Node.js does:
And Chrome:
|
ry
pushed a commit
that referenced
this issue
Oct 8, 2018
ry
added a commit
to ry/deno
that referenced
this issue
Oct 12, 2018
- Add --types command line flag. - Add metrics() - Add redirect follow feature denoland#934 - Fix clearTimer bug denoland#942 - Improve error printing denoland#935 - Expose I/O interfaces Closer, Seeker, ReaderCloser, WriteCloser, ReadSeeker, WriteSeeker, ReadWriteCloser, ReadWriteSeeker - Fix silent death on double await denoland#919 - Add Conn.closeRead() and Conn.closeWrite() denoland#903
Merged
ry
added a commit
to ry/deno
that referenced
this issue
Oct 12, 2018
- Fix promise reject issue (denoland#936) - Add --types command line flag. - Add metrics() - Add redirect follow feature denoland#934 - Fix clearTimer bug denoland#942 - Improve error printing denoland#935 - Expose I/O interfaces Closer, Seeker, ReaderCloser, WriteCloser, ReadSeeker, WriteSeeker, ReadWriteCloser, ReadWriteSeeker - Fix silent death on double await denoland#919 - Add Conn.closeRead() and Conn.closeWrite() denoland#903
ry
added a commit
that referenced
this issue
Oct 12, 2018
- Fix promise reject issue (#936) - Add --types command line flag. - Add metrics() - Add redirect follow feature #934 - Fix clearTimer bug #942 - Improve error printing #935 - Expose I/O interfaces Closer, Seeker, ReaderCloser, WriteCloser, ReadSeeker, WriteSeeker, ReadWriteCloser, ReadWriteSeeker - Fix silent death on double await #919 - Add Conn.closeRead() and Conn.closeWrite() #903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The uncaught error handler seems to always try to display the
stack
property of the caught value, regardless of whether that value is an instance ofError
or even an object at all.This can either just be confusing:
Or worse, fail entirely:
It isn't good practice to throw values that aren't instances of
Error
, but it happens.The text was updated successfully, but these errors were encountered: