Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno.bundle() option target 2015 is invalid in v1.5.2/v1.5.3 #8411

Closed
iugo opened this issue Nov 17, 2020 · 6 comments
Closed

Deno.bundle() option target 2015 is invalid in v1.5.2/v1.5.3 #8411

iugo opened this issue Nov 17, 2020 · 6 comments
Labels
cli related to cli/ dir needs discussion this topic needs further discussion to determine what action to take

Comments

@iugo
Copy link
Contributor

iugo commented Nov 17, 2020 •
edited
Loading

https://github.com/iugo/deno-with-ts/tree/a290847df25c8ac505afecad3fd5bfe3845d66a4

  1. deno upgrade --version 1.4.6, deno run --unstable --allow-all run.ts.
  2. deno upgrade --version 1.5.3, deno run --unstable --allow-all run.ts.
version result
v1.4.6 valid
v1.5.0 valid
v1.5.1 valid
v1.5.2 invalid
v1.5.3 invalid

In v1.5.2+, deno loses the ability to compile.
@lucacasonato
Copy link
Member

lucacasonato commented Nov 17, 2020 •
edited
Loading

@iugo The repository is private.

cc @kitsonk

@lucacasonato lucacasonato added cli related to cli/ dir needs info needs further information to be properly triaged labels Nov 17, 2020
@iugo
Copy link
Contributor Author

iugo commented Nov 17, 2020 •
edited
Loading

@iugo The repository is private.

cc @kitsonk

Sorry, it has been fixed now.

@iugo iugo changed the title Deno.bundle() option target 2015 is invalid in v1.5.3 Deno.bundle() option target 2015 is invalid in v1.5.2/v1.5.3 Nov 17, 2020
@lucacasonato lucacasonato added needs discussion this topic needs further discussion to determine what action to take and removed needs info needs further information to be properly triaged labels Nov 17, 2020
@stale
Copy link

stale bot commented Jan 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 16, 2021
@kt3k
Copy link
Member

kt3k commented Jan 16, 2021 •
edited
Loading

Do we support es3 target? (ref: https://github.com/iugo/deno-with-ts/blob/a290847df25c8ac505afecad3fd5bfe3845d66a4/run.ts )

@stale stale bot removed the stale label Jan 16, 2021
@satyarohith
Copy link
Member

Do we support es3 target? (ref: https://github.com/iugo/deno-with-ts/blob/a290847df25c8ac505afecad3fd5bfe3845d66a4/run.ts )

From lib.deno.unstable.d.ts, yes.

FYI: The compiler APIs consolidated into Deno.emit() (See #8799).

@kitsonk
Copy link
Contributor

kitsonk commented Jan 16, 2021

ES3 target may or may not work. We don't test for it and if there are issue with it we won't fix them.

@kitsonk kitsonk closed this as completed Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli related to cli/ dir needs discussion this topic needs further discussion to determine what action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@iugo @kt3k @kitsonk @lucacasonato @satyarohith