refactor(cli): runtime compiler APIs consolidated to Deno.emit() #8799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
added
the
breaking change
kitsonk
force-pushed
the
kitsonk/issue4752
branch
from
0634813 to
5c32d3e
Compare
bartlomieju
approved these changes
Dec 30, 2020
Like what? It isn't bike-shedding if there isn't a suggestion. |
kitsonk
force-pushed
the
kitsonk/issue4752
branch
from
15329b9 to
9bb89a6
Compare
Alright, I retract my words, I can't come up with a better name for this API. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4752
This is a breaking change that replaces the unstable
Deno.compile(),Deno.bundle(), andDeno.transpileOnly()APIs with a single API,Deno.emit()which behaves more in line with the waydeno run,deno cache, anddeno bundlework, where there is acheckoption which determines if the program is checked or not. In addition, theDeno.emit()API supports import maps, which the previous APIs did not. (It should be noted, that Deno does not transform any paths with an import map, so any consumers of the emitted code would need to be able to leverage the same resolutions as the import map).