Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: 1.39.3 and 1.39.4 breaks the denoland.vscode-deno vscode formatter on windows #21971

Closed
king8fisher opened this issue Jan 17, 2024 · 2 comments · Fixed by #21972
Closed
Labels
bug Something isn't working correctly windows Related to Windows platform

Comments

@king8fisher
Copy link
Contributor

Version: Deno 1.39.3, 1.39.4
Seems to be affecting Windows only. Mac works fine. Can't reproduce on Linux.

Neither the formatting on save nor manual request to format work on the affected versions.

deno upgrade --version 1.39.2 restores the formatter (after rebooting VSCode), no need to downgrade the vscode extension which is 3.31.0 / 2023.12.28
Formatting on save or manual request to format works as expected.

My local .vscode settings.json settings are:

  "javascript.format.enable": false,
  "typescript.format.enable": false,
  "editor.defaultFormatter": "denoland.vscode-deno",
  "editor.formatOnSave": true,
  "[typescriptreact]": {
    "editor.defaultFormatter": "denoland.vscode-deno"
  },
  "[typescript]": {
    "editor.defaultFormatter": "denoland.vscode-deno"
  },
  "[javascriptreact]": {
    "editor.defaultFormatter": "denoland.vscode-deno"
  },
  "[javascript]": {
    "editor.defaultFormatter": "denoland.vscode-deno"
  },
  "[json]": {
    "editor.defaultFormatter": "denoland.vscode-deno"
  },
  "[jsonc]": {
    "editor.defaultFormatter": "denoland.vscode-deno"
  },
  "editor.codeActionsOnSave": {
    "source.organizeImports": "never",
    "source.fixAll": "never"
  },
  "[css]": {
    "editor.defaultFormatter": "vscode.css-language-features"
  }

My global settings has nothing regarding formatting.

@dsherret dsherret changed the title regression: 1.39.3 and 1.39.4 breaks the denoland.vscode-deno vscode formatter regression: 1.39.3 and 1.39.4 breaks the denoland.vscode-deno vscode formatter on windows Jan 17, 2024
@dsherret dsherret added bug Something isn't working correctly windows Related to Windows platform labels Jan 17, 2024
@dsherret
Copy link
Member

This should be fixed in canary now (deno upgrade --canary). Please let me know if not.

@king8fisher
Copy link
Contributor Author

It works! Excellent! You are so fast it's pretty amazing! Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly windows Related to Windows platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants