-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting transitive mappings for npm: specifiers #18191
Comments
Thanks @dsherret for guiding me to this open thread, so currently, does it not work with npm packages? I also tried this, and it does not seem to work.
|
@dsherret Just to clarify:
|
Am I right in thinking the same issue applies to JSR dependencies? If so, will the byonm workaround work for those until this is addressed? |
npm doesn't support import maps so in order to override deps of deps using byonm in deno, you'd need to specify npm overrides https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides ...then run an explicit
Yeah, this issue would cover that.
No, this issue is unrelated to JSR dependencies unless you're pulling in JSR dependencies via npm. If just using |
This makes us less suspectable to esm.sh being down. A full transition is blocked on denoland/deno#18191.
This makes us less suspectable to esm.sh being down. A full transition is blocked on denoland/deno#18191.
I was just running some tests to see if I can map transitive dependencies with Deno
npm:
specifiers along the lines of:Where there is an import of
import 'react'
against the above import map in Deno.Supporting the scoped
npm:[email protected]
in the above would be great for extending import maps support to npm specifiers without treating the version resolution as a fully opaque process. It would also make it easier to switch from Deno npm packages to eg JSPM versions of packages for moving from a browser to server workflow.Has this been discussed at all, or are there any particular hurdles to achieving this kind of support, would be really interested to hear opinions!
//cc @dsherret
The text was updated successfully, but these errors were encountered: