-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(publish): track templateVersion on initialization #3036
base: master
Are you sure you want to change the base?
Conversation
await this._cloneTemplate(opts); | ||
const templateVersion = | ||
NextjsExportPodUtils.templateVersion(config) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if config version exceeds engine Version? Shouldn't we do Math.min(configVersion?, engineVersion)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want to do a min in this case because configVersion
is source of truth. if the engineVersion is lower, we need to ask the user to update the engine because they've published using a higher version. i've done a writeup of this here, will also share as an async > https://docs.google.com/document/d/1dZ3X039TqQyUMaRYx9KJSFVpJMEHgtjRbqdAdFDGWX8/edit
enhance(publish): track templateVersion on initialization
Currently,
dendron publish
will always try to fetch the latest version of the template from git.This isn't great as the latest version can have breaking changes.
This commit is the first in a series that adds versioning to the publishing templates to make upgrades and deployment less brittle.
templateVersion
config variable that tracks version of template being publisheddendron publish init
templateVersion
on initializationThe model we are moving to:
Next:
dendron publish upgrade
whichtemplateVersion
commanddendron publish upgrade
with tracked versions (vs deploying from the latest version)