Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against Net8 #251

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Build against Net8 #251

merged 2 commits into from
Jan 31, 2024

Conversation

TheAngryByrd
Copy link
Collaborator

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd merged commit f6fd013 into v5 Jan 31, 2024
@TheAngryByrd TheAngryByrd changed the title Net8 Build against Net8 Jan 31, 2024
@TheAngryByrd TheAngryByrd mentioned this pull request Jan 31, 2024
4 tasks
@TheAngryByrd TheAngryByrd added this to the v5 milestone Feb 8, 2024
TheAngryByrd added a commit that referenced this pull request Dec 7, 2024
* net8 tfm

* Update README
@TheAngryByrd TheAngryByrd mentioned this pull request Dec 7, 2024
6 tasks
TheAngryByrd added a commit that referenced this pull request Dec 7, 2024
* Remove Ply and update to FSharp 6 (#248)

* remove Ply and update to FSharp 6

* Cleanup dependencies

* Fix fsharp.core warning

* Don't build so much

* Asyncinterfaces (#250)

* use  Microsoft.Bcl.AsyncInterfaces

* Updated IcedTasks to 0.11.0

* Fix for fable

* Net8 (#251)

* net8 tfm

* Update README

* Fix CI cancellation issues

* Build on  macos-14

* 205 overload resolution (#252)

* Missed this in net8 additions

* Fix overload resolution issues in Core

* Fix overload resolution issues in Tasks/Hopac

* Fix overload resolution issues in CancellableTaskResult

* WIP: TaskValidtionCE

* Wip merge sources

* Fix MergeSources for CTValidation

* cleanup

* Ensure IAsyncDisposable tests

* ignore nuget stuff

* feat(Seq)!: Add sequenceResultA, align sequenceResultM (#255)

* Roll on '24

* refactor(Seq.sequenceResultM)!: Change Ok to Array

* docs: sequenceResultM

* feat(Seq): sequenceResultA

* f sequenceResultM docs

* Supress compile error

* Fix proposed version

* Cleanup build

* 209 remove MergeSources (and!) from some implementations (#261)

* Remove MergeSources from resultCE

* Remove MergeSources from AsyncResult

* Remove MergeSources from ResultOption

* Fixup resultOption docs

* Remove MergeSources from OptionCE

* Remove MergeSources from ValueOptionCE

* remove MergeSources Option/ValueOption

* MSBuild.StructuredLogger update

* disable binlog for fake

* Many updates

* fix residual rebase artifacts

* Merge TaskResult into Core lib (#285)

* silence FS3511

---------

Co-authored-by: Ruben Bartelink <[email protected]>
TheAngryByrd added a commit that referenced this pull request Dec 7, 2024
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd
- BREAKING: [Remove MergeSources (and!) from some implementations](#261)  Credits @TheAngryByrd
- BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd
- This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library.
- [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd
- [Build against Net8](#251) Credits @TheAngryByrd
- [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd
- [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink
- [feat(Seq): sequenceResultA](#255) Credits @bartelink
-
TheAngryByrd added a commit that referenced this pull request Dec 21, 2024
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd
- BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261)  Credits @TheAngryByrd
- BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd
- This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library.
- BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder
- [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd
- [Build against Net8](#251) Credits @TheAngryByrd
- [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd
- [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink
- [feat(Seq): sequenceResultA](#255) Credits @bartelink
- [Updated uses of Seq.append](#290) Credits @1eyewonder
-
TheAngryByrd added a commit that referenced this pull request Jan 6, 2025
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd
- BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261)  Credits @TheAngryByrd
- BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd
- This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library.
- BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder
- [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd
- [Build against Net8](#251) Credits @TheAngryByrd
- [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd
- [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink
- [feat(Seq): sequenceResultA](#255) Credits @bartelink
- [Updated uses of Seq.append](#290) Credits @1eyewonder
- [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt
- [Add Require and Check helper methods](#295) Credits @PI-Gorbo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant