Skip to content

Commit

Permalink
default attachRequired: true and enable external-attacher
Browse files Browse the repository at this point in the history
Signed-off-by: Travis Glenn Hansen <[email protected]>
  • Loading branch information
travisghansen committed Jul 17, 2023
1 parent edbac2a commit b425a80
Show file tree
Hide file tree
Showing 8 changed files with 44 additions and 11 deletions.
20 changes: 20 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
# 0.14.0

Released 2023-07-16

BREAKING CHANGES: some default values have changed which should be enabled on
all drivers *except* the `*-local` drivers. In other words, you must explicitly
disable the defaults now for `*-local` drivers with the following:

```yaml
csiDriver:
attachRequired: false

controller:
externalAttacher:
enabled: false
```
- bump sidecars versions
- default `attachRequired: true` and enable `external-attacher` by default (see https://github.com/democratic-csi/democratic-csi/issues/307)

# 0.13.5

Released 2022-09-20
Expand Down
2 changes: 1 addition & 1 deletion stable/democratic-csi/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v1
appVersion: "1.0"
description: csi storage for container orchestration systems
name: democratic-csi
version: 0.13.7
version: 0.14.0
4 changes: 4 additions & 0 deletions stable/democratic-csi/examples/local-hostpath.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
csiDriver:
# should be globally unique for a given cluster
name: "org.democratic-csi.local-hostpath"
attachRequired: false
storageCapacity: true
fsGroupPolicy: File

Expand Down Expand Up @@ -41,6 +42,9 @@ controller:
- --enable-capacity=true
- --capacity-ownerref-level=1

externalAttacher:
enabled: false

# distributed support is not yet ready
externalResizer:
enabled: false
Expand Down
4 changes: 4 additions & 0 deletions stable/democratic-csi/examples/zfs-local-dataset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
csiDriver:
# should be globally unique for a given cluster
name: "org.democratic-csi.zfs-local-dataset"
attachRequired: false
storageCapacity: true
fsGroupPolicy: File

Expand Down Expand Up @@ -42,6 +43,9 @@ controller:
- --enable-capacity=true
- --capacity-ownerref-level=1

externalAttacher:
enabled: false

# distributed support is not yet ready
externalResizer:
enabled: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
csiDriver:
# should be globally unique for a given cluster
name: "org.democratic-csi.zfs-ephemeral"
attachRequired: false
volumeLifecycleModes:
- Ephemeral

Expand Down
4 changes: 4 additions & 0 deletions stable/democratic-csi/examples/zfs-local-zvol.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
csiDriver:
# should be globally unique for a given cluster
name: "org.democratic-csi.zfs-local-zvol"
attachRequired: false
storageCapacity: true
fsGroupPolicy: File

Expand Down Expand Up @@ -44,6 +45,9 @@ controller:
- --enable-capacity=true
- --capacity-ownerref-level=1

externalAttacher:
enabled: false

# distributed support is not yet ready
externalResizer:
enabled: false
Expand Down
16 changes: 8 additions & 8 deletions stable/democratic-csi/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ csiDriver:
version: 1.5.0
# create the kubernetes CSIDriver
enabled: true
attachRequired: false
attachRequired: true
podInfoOnMount: true
# https://kubernetes-csi.github.io/docs/support-fsgroup.html
# k8s 1.19+ (ignored otherwise)
Expand Down Expand Up @@ -73,8 +73,8 @@ controller:

# https://kubernetes-csi.github.io/docs/external-attacher.html
externalAttacher:
enabled: false
image: registry.k8s.io/sig-storage/csi-attacher:v3.4.0
enabled: true
image: registry.k8s.io/sig-storage/csi-attacher:v4.3.0
args:
- --v=5
- --leader-election
Expand All @@ -89,7 +89,7 @@ controller:
# https://kubernetes-csi.github.io/docs/external-provisioner.html
externalProvisioner:
enabled: true
image: registry.k8s.io/sig-storage/csi-provisioner:v3.1.0
image: registry.k8s.io/sig-storage/csi-provisioner:v3.5.0
args:
- --v=5
- --leader-election
Expand All @@ -105,7 +105,7 @@ controller:
# https://kubernetes-csi.github.io/docs/external-resizer.html
externalResizer:
enabled: true
image: registry.k8s.io/sig-storage/csi-resizer:v1.4.0
image: registry.k8s.io/sig-storage/csi-resizer:v1.8.0
args:
- --v=5
- --leader-election
Expand All @@ -122,7 +122,7 @@ controller:
enabled: true
# 1.20+ should use v4.0.0+
# READ *before* updating from beta https://github.com/kubernetes-csi/external-snapshotter#usage
image: registry.k8s.io/sig-storage/csi-snapshotter:v5.0.1
image: registry.k8s.io/sig-storage/csi-snapshotter:v6.2.2
args:
- --v=5
- --leader-election
Expand All @@ -137,7 +137,7 @@ controller:
# https://github.com/kubernetes-csi/external-health-monitor
externalHealthMonitorController:
enabled: false
image: registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.4.0
image: registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.9.0
args:
- --v=5
- --leader-election
Expand Down Expand Up @@ -251,7 +251,7 @@ node:
# https://kubernetes-csi.github.io/docs/node-driver-registrar.html
driverRegistrar:
enabled: true
image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.5.1
image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
args:
- --v=5
- --csi-address={{ .csiSocketAddress }}
Expand Down
4 changes: 2 additions & 2 deletions stable/snapshot-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.3
version: 0.2.4

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "6.0.1"
appVersion: "6.2.2"

0 comments on commit b425a80

Please sign in to comment.