Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail on unexpected exception + handle mac os docker #904

Merged
merged 9 commits into from
Nov 30, 2020
Merged

Conversation

glicht
Copy link
Contributor

@glicht glicht commented Nov 26, 2020

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
related: https://github.com/demisto/etc/issues/31000

Description

Screenshots

Paste here any images that will help the reviewer

Must have

  • Tests
  • Documentation

@glicht glicht requested review from anara123 and GalRabin November 26, 2020 11:24
@lgtm-com
Copy link

lgtm-com bot commented Nov 26, 2020

This pull request introduces 1 alert when merging 7dc8fa7 into 08ad5cf - view on LGTM.com

new alerts:

  • 1 for Unnecessary pass

@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2020

Pull Request Test Coverage Report for Build d66ebd04-e5a2-4514-9e47-0c180c315560

  • 27 of 45 (60.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 86.608%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/lint/lint_manager.py 2 3 66.67%
demisto_sdk/commands/lint/helpers.py 0 4 0.0%
demisto_sdk/commands/lint/linter.py 25 38 65.79%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/lint/helpers.py 1 65.04%
demisto_sdk/commands/lint/linter.py 1 69.55%
Totals Coverage Status
Change from base Build 9aaa7fd6-a3b9-4e29-8ebd-0644cc20a4fd: -0.02%
Covered Lines: 12165
Relevant Lines: 14046

💛 - Coveralls

@glicht glicht requested a review from orhovy November 27, 2020 08:10
@glicht
Copy link
Contributor Author

glicht commented Nov 27, 2020

@GalRabin @orhovy I enabled mypy and vulture testing when no docker engine is available. Also added a fix that if no docker engine is available we get the py version from the yml. Additionally, if we are in CI build of content and docker for some reason is not available we will fail.

@glicht glicht merged commit 869e11f into master Nov 30, 2020
@glicht glicht deleted the linter-fix-macos branch November 30, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants