Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate silent-Playbook do not have a README file #4723

Merged
merged 10 commits into from
Dec 22, 2024
Merged

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Dec 22, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12158

Description

Validate silent-Playbook do not have a README file

Copy link

Changelog(s) in markdown:

  • Added Validation that silent-Playbook do not have a README file. #4723

@moishce moishce requested a review from dantavori December 22, 2024 08:27
…eadme

# Conflicts:
#	demisto_sdk/commands/validate/sdk_validation_config.toml
#	demisto_sdk/commands/validate/tests/PB_validators_test.py
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, see notes

@moishce moishce marked this pull request as ready for review December 22, 2024 14:30
@moishce moishce merged commit 8b3429d into master Dec 22, 2024
23 checks passed
@moishce moishce deleted the silent-readme branch December 22, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants