Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RN111 #4714

Merged
merged 3 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/4714.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- description: Fixed an issue where RN111 would falsely failed with missing docker entry message.
YuvHayun marked this conversation as resolved.
Show resolved Hide resolved
type: fix
pr_number: 4714
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@ def obtain_invalid_content_items(
and content_item.docker_image != old_obj.docker_image # type:ignore[attr-defined]
and (
docker_entry := self.get_docker_image_entry(
content_item.pack.release_note.file_content, content_item.name
content_item.pack.release_note.file_content,
content_item.display_name,
)
)
and content_item.docker_image != docker_entry
and content_item.docker_image not in docker_entry
]

def get_docker_image_entry(self, rn: str, content_item_name: str) -> str:
Expand All @@ -52,8 +53,11 @@ def get_docker_image_entry(self, rn: str, content_item_name: str) -> str:
if item.startswith(content_item_name):
for entry in item.split("- "):
if entry.startswith("Updated the Docker image to: "):
docker = entry.replace("Updated the Docker image to: ", "")[
1:-2
docker_entry = entry.replace(
"Updated the Docker image to: ", ""
)
docker = docker_entry[
docker_entry.find("*") + 1 : docker_entry.rfind("*")
]
break
return docker
Loading