Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSUP-45578 #38109

Merged
merged 7 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Packs/CommonScripts/ReleaseNotes/1_19_9.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#### Scripts

##### HttpV2

Fixed an issue where the *timeout_between_retries* argument was treated as string instead of being converted to a number.
tcarmeli1 marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion Packs/CommonScripts/Scripts/HttpV2/HttpV2.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def main():
save_as_file = args.get('save_as_file', 'no')
file_name = args.get('filename', 'http-file')
timeout = arg_to_number(args.get('timeout', 10))
timeout_between_retries = args.get('timeout_between_retries', 5)
timeout_between_retries = arg_to_number(args.get('timeout_between_retries', 5))
retry_count = arg_to_number(args.get('retry_count', 3))
proxy = argToBoolean(args.get('proxy', False))
verify = argToBoolean(not args.get('unsecure', False))
Expand Down
18 changes: 9 additions & 9 deletions Packs/CommonScripts/Scripts/HttpV2/HttpV2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ args:
- description: |-
Specify a hash of headers to send with the request.
Headers can be of string type but need to be formatted in the following ways:
`{"key1": "value1", "key2": "value2"}` or `"key1": "value1", "key2": "value2"`
`{"key1": "value1", "key2": "value2"}` or `"key1": "value1", "key2": "value2"`.
name: headers
type: keyValue
- description: Specify the body of the request.
Expand All @@ -29,7 +29,7 @@ args:
xml (text/xml)
form (application/x-www-form-urlencoded)
data (multipart/form-data)
If you choose to define a different type, please include the full type name, e.g: application/pdf
If you choose to define a different type, please include the full type name, e.g: application/pdf.
name: request_content_type
- description: |-
Specify the Accept header for the request - the response content type.
Expand All @@ -38,7 +38,7 @@ args:
xml (text/xml)
form (application/x-www-form-urlencoded)
data (multipart/form-data)
If you choose to define a different type, please include the full type name, e.g: application/pdf
If you choose to define a different type, please include the full type name, e.g: application/pdf.
name: response_content_type
- auto: PREDEFINED
defaultValue: raw_response
Expand Down Expand Up @@ -81,23 +81,23 @@ args:
- yes
- no
- defaultValue: http-file
description: filename
description: filename.
name: filename
- auto: PREDEFINED
defaultValue: 'False'
description: Trust any certificate (not secure)
description: Trust any certificate (not secure).
name: unsecure
predefined:
- 'True'
- 'False'
- auto: PREDEFINED
defaultValue: 'False'
description: Use system proxy settings
description: Use system proxy settings.
name: proxy
predefined:
- 'True'
- 'False'
comment: Sends a HTTP request with advanced capabilities
comment: Sends a HTTP request with advanced capabilities.
commonfields:
id: HttpV2
version: -1
Expand All @@ -107,10 +107,10 @@ outputs:
description: The number that indicates the status of the request.
type: String
- contextPath: HttpRequest.Response.StatusText
description: The text corresponding to the status code
description: The text corresponding to the status code.
type: String
- contextPath: HttpRequest.Response.URL
description: The URL of the response
description: The URL of the response.
type: String
- contextPath: HttpRequest.Response.ParsedBody
description: The parsed response, according to `parse_response_as` argument.
Expand Down
2 changes: 1 addition & 1 deletion Packs/CommonScripts/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Common Scripts",
"description": "Frequently used scripts pack.",
"support": "xsoar",
"currentVersion": "1.19.8",
"currentVersion": "1.19.9",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
Loading