Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SplunkPy] MyPy In Docker #38035

Merged
merged 3 commits into from
Jan 9, 2025
Merged

[SplunkPy] MyPy In Docker #38035

merged 3 commits into from
Jan 9, 2025

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Jan 8, 2025

Related Issues

Related: link to the issue

Description

image

@shmuel44 shmuel44 self-assigned this Jan 8, 2025
@shmuel44 shmuel44 requested a review from BEAdi January 8, 2025 07:33
@shmuel44 shmuel44 marked this pull request as ready for review January 8, 2025 07:33
@shmuel44 shmuel44 requested a review from ilappe as a code owner January 8, 2025 07:33
Copy link

github-actions bot commented Jan 8, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/SplunkPy/Integrations/SplunkPy
   SplunkPy.py153139574%117–118, 156, 158, 183–184, 188–191, 193–194, 198–201, 224, 235, 309, 313–315, 318–321, 348–350, 360, 494, 496, 609–610, 616, 637, 656–658, 660, 732–733, 746–751, 772–773, 775–777, 779, 781, 857–862, 864, 868–869, 1072–1073, 1150–1151, 1153, 1172–1173, 1208–1217, 1252–1253, 1255, 1273, 1320–1321, 1323, 1328–1329, 1335, 1338–1339, 1371–1373, 1381, 1443–1445, 1447–1448, 1510, 1542, 1596–1597, 1663, 1694–1696, 1698, 1723–1724, 1728, 1731, 1734–1742, 1745–1746, 1748, 1750–1751, 1781–1783, 1785, 1787–1788, 1790–1794, 1796–1798, 1800, 1808, 1810–1813, 1817–1825, 1827–1828, 1996, 1999, 2002, 2005, 2008–2011, 2013, 2017–2020, 2023, 2025–2030, 2032, 2162, 2190, 2194, 2203, 2213, 2217, 2238, 2240, 2242, 2244, 2264, 2267, 2272–2276, 2284, 2286–2288, 2330, 2358, 2406, 2412, 2416–2421, 2423–2425, 2427–2428, 2430, 2432–2434, 2457–2458, 2496, 2507–2509, 2511–2512, 2514, 2525, 2532–2536, 2540, 2542, 2550–2558, 2560, 2562–2565, 2567–2568, 2599–2604, 2612–2615, 2618–2621, 2644–2647, 2672, 2709, 2733, 2762, 2790, 2805, 2817, 2824–2826, 2828–2829, 2846–2848, 2871, 2878–2882, 2888–2889, 2897–2898, 2914–2918, 2921, 2923, 2929–2936, 2938–2939, 2941–2942, 2948–2956, 2958–2959, 2965–2966, 2972–2973, 2975–2977, 2979, 2984–2991, 2993, 2998, 3005–3008, 3017–3020, 3024–3027, 3042, 3044–3045, 3047–3048, 3050, 3059, 3063–3070, 3075, 3091–3092, 3099–3102, 3130–3137, 3141–3142, 3144–3149
TOTAL153139574% 

Tests Skipped Failures Errors Time
234 0 💤 0 ❌ 0 🔥 3.526s ⏱️

Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the docker image is fine and fix pre-commit errors

@shmuel44 shmuel44 changed the title SplunkPy [SplunkPy] MyPy In Docker Jan 8, 2025
@shmuel44 shmuel44 merged commit c991690 into master Jan 9, 2025
20 checks passed
@shmuel44 shmuel44 deleted the sk_SplunkPy_mypy branch January 9, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants