Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pre Commit] MyPy In Docker #37864

Merged
merged 8 commits into from
Jan 21, 2025
Merged

[Pre Commit] MyPy In Docker #37864

merged 8 commits into from
Jan 21, 2025

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Dec 30, 2024

Related Issues

fixes: link to the issue
Related: https://jira-dc.paloaltonetworks.com/browse/CIAC-12625

Description

Remove The Skip Flag From The MyPy In Docker Hook

content nightly: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/1975140

@shmuel44 shmuel44 self-assigned this Dec 30, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to the content\sdk nightly run with this unskip, and link the Jira ticket to a new ticket assigned to you to remove the old mypy in ~2 weeks.

@shmuel44 shmuel44 merged commit 66a24a9 into master Jan 21, 2025
20 checks passed
@shmuel44 shmuel44 deleted the sk_unskip_mypy_in_docker branch January 21, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants