Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nozomi fix lost incidents #37351

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Nozomi fix lost incidents #37351

merged 11 commits into from
Dec 9, 2024

Conversation

nicoloereni
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@nicoloereni
NNPANXSOAR-6
8db4988 
* use record_created_at to paginate
* fix tests
@nicoloereni
NNPANXSOAR-6
7961d40 
* use requests as http client to fix verify SSL issues
* make code more stable
@nicoloereni
NNPANXSOAR-6
1342724 
* updated documentation
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Nov 21, 2024
@content-bot content-bot changed the base branch from master to contrib/NozomiNetworks_nozomi_fix_lost_incidents November 21, 2024 15:21
@content-bot content-bot requested a review from YairGlik November 21, 2024 15:22
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YairGlik will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @nicoloereni, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Nov 21, 2024
YairGlik
YairGlik requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@YairGlik YairGlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Packs/NozomiNetworks/Integrations/NozomiNetworks/NozomiNetworks.py Show resolved Hide resolved
@nicoloereni nicoloereni requested a review from YairGlik November 26, 2024 10:56
@YairGlik
Copy link
Contributor

YairGlik commented Dec 1, 2024

Hi @nicoloereni,
We're ready for a demo. Please let me know when you're available for one over DFIR.
We'll talk about the http_request in the meeting.

@nicoloereni
Copy link
Contributor Author

Hi @nicoloereni, We're ready for a demo. Please let me know when you're available for one over DFIR. We'll talk about the http_request in the meeting.

Hi @YairGlik, perfect!
I'm in the CET timezone, I'm sending my availability via Slack.
Thanks

@nicoloereni nicoloereni mentioned this pull request Dec 3, 2024
Merged
5 tasks
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nicoloereni
Copy link
Contributor Author

nicoloereni commented Dec 4, 2024 •
edited
Loading

@YairGlik
What can I do to make the demisto/pull-check green?

@nicoloereni
* add release notes
0c2cdb4 
* bump version
@nicoloereni
* update release notes
640a177 
* make linter happy
@nicoloereni
Copy link
Contributor Author

@YairGlik
All checks are green, if you want you can merge it, thanks

@YairGlik YairGlik added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 5, 2024
@Shellyber
Copy link
Contributor

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@Shellyber
Copy link
Contributor

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/1757182

@Shellyber Shellyber removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 5, 2024
@YairGlik YairGlik added post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Dec 5, 2024
@Shellyber
Copy link
Contributor

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@Shellyber
Copy link
Contributor

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/1759405

@Shellyber Shellyber removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 5, 2024
@nicoloereni
Copy link
Contributor Author

@YairGlik @Shellyber

Our common customer has reached out to request an ETA for the fix of this issue. They are looking forward to having this resolved soon.
Thank you for your support!

@YairGlik
Copy link
Contributor

YairGlik commented Dec 9, 2024 •
edited
Loading

Hello @nicoloereni,

Thank you for your contribution to the project! There are a few small fixes needed to get your changes ready for merging:

Description File: A description file is missing for the integration. Please add a file named NozomiNetworks_description.md and include the necessary description.

If you need any help or further clarification, feel free to reach out.
Thank you and good luck!

@YairGlik YairGlik added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 9, 2024
@Shellyber
Copy link
Contributor

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@Shellyber
Copy link
Contributor

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/1777902

@Shellyber Shellyber removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 9, 2024
@YairGlik YairGlik merged commit 54b490d into demisto:contrib/NozomiNetworks_nozomi_fix_lost_incidents Dec 9, 2024
21 checks passed
@kobymeir kobymeir mentioned this pull request Dec 9, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

YairGlik pushed a commit that referenced this pull request Dec 10, 2024
@kobymeir @nicoloereni
Nozomi fix lost incidents (#37351) (#37628)
beac0ce 
* NNPANXSOAR-6
* use record_created_at to paginate
* fix tests

* NNPANXSOAR-6
* use requests as http client to fix verify SSL issues
* make code more stable

* NNPANXSOAR-6
* updated documentation

* NNPANXSOAR-6
* make linter happy

* * add release notes
* bump version

* * update release notes
* make linter happy

* * make linter happy again

* * make linter happy again

Co-authored-by: Nicolò <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YairGlik YairGlik YairGlik approved these changes

Assignees

@YairGlik YairGlik

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved post-demo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicoloereni @content-bot @YairGlik @CLAassistant @Shellyber