Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CortexCoreIR http_request #35206

Merged
merged 13 commits into from
Jul 4, 2024
Merged

Fixed CortexCoreIR http_request #35206

merged 13 commits into from
Jul 4, 2024

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jul 3, 2024

Status

  • In Progress

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-39134

Description

  • Adding a function to CommonServerPython to check if the platform is using an engine.
  • Adding to FORWARD_USER_RUN_RBAC check that the platform is using an engine.
  • Removing using_base_client_http_request parameter from coreIRAPIModule _http_request.

Copy link

github-actions bot commented Jul 3, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/CoreIRApiModule
   CoreIRApiModule.py164125684%228, 266, 269, 274, 288, 319, 326, 340, 347, 354, 376, 422, 427, 468, 483, 494, 506, 565–566, 572–577, 602, 608, 614, 626, 636, 642, 661, 673, 679, 685, 697, 707, 713, 749, 763, 788, 817, 833, 835, 943, 973, 976, 986, 1055, 1061, 1081, 1087, 1089, 1116, 1132, 1318, 1342, 1348, 1361, 1363–1364, 1366, 1372–1373, 1379–1380, 1386, 1393–1394, 1427, 1429, 1475, 1482, 1489, 1495, 1501, 1508, 1515, 1525, 1555, 1631–1634, 1636–1642, 1647, 1652–1655, 1657–1658, 1660–1661, 1663–1667, 1669–1670, 1672, 1676, 1683–1684, 1699–1700, 1716, 1721, 1729, 1777–1779, 1783, 1786, 1810, 1895, 1901, 1905, 1909, 1914, 1920, 1932–1933, 1939, 1944, 1950, 1953–1955, 1987, 1990–1993, 2107, 2180, 2186, 2190, 2194, 2197, 2401, 2619, 2630, 2633–2635, 2639–2642, 2646–2647, 2653, 2655–2659, 2663, 2669, 2671–2672, 2674, 2678–2681, 2683, 2690, 2692–2693, 2696–2700, 2703, 2705, 2707, 2709–2712, 2716–2717, 2719–2724, 2726, 2757, 2932–2935, 2939–2940, 2951, 3051, 3080, 3082, 3084, 3324–3325, 3417–3419, 3427, 3448, 3562–3565, 3651, 3659, 3663–3664, 3722–3724, 3730, 3769, 3783, 3790, 3797, 3839, 3846, 3853, 3860, 3867, 4071, 4107–4110, 4112–4114, 4217, 4251, 4257, 4264, 4266, 4273, 4275, 4293, 4316
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py445067384%169–172, 183, 185, 421, 463, 559, 585–589, 614, 629, 769–770, 779, 820–821, 839, 869–873, 877–879, 921, 1008–1016, 1060–1065, 1099–1101, 1231–1235, 1238–1239, 1241–1243, 1257–1259, 1261, 1327, 1340, 1353, 1361–1363, 1365, 1378, 1386, 1473–1474, 1529, 1551–1552, 1555, 1561, 1563, 1565, 1659, 1704, 1778–1779, 1783–1784, 1823–1824, 1838–1843, 1845, 1913, 1996, 1998, 2018, 2048, 2052, 2094, 2273, 2297, 2336–2337, 2417–2418, 2420, 2433–2440, 2442, 2519–2521, 2535, 2548, 2579, 2585–2589, 2591–2593, 2595, 2599–2600, 2602, 2615–2621, 2625, 2629–2631, 2637–2638, 2650, 2678, 2681, 2686, 2706, 2712, 2714, 2716, 2736, 2739, 2751, 2797–2805, 2807, 2866, 2888, 2908, 2966, 2978–2979, 3091, 3093, 3268, 3278, 3284, 3293, 3299, 3313, 3369, 3384, 3386, 3417–3422, 3425, 3476–3477, 3480, 3646–3647, 3650, 3757, 3760, 3985, 3988, 3991, 3994, 3999, 4008, 4034, 4040, 4043, 4052, 4054, 4170–4171, 4195, 4197, 4216, 4219, 4222, 4290, 4311, 4313, 4449, 4467, 4479, 4515, 4517, 4691–4692, 4770, 4772, 4797, 4812–4828, 4831, 4835–4836, 4838–4839, 4841–4842, 4844–4845, 4847–4848, 4850–4851, 4853–4854, 4856–4857, 4859–4860, 4862–4863, 4865–4866, 4868–4869, 4871–4872, 4874, 4876–4877, 4879–4882, 4884–4886, 4888, 4890, 4894, 4965, 4997, 5003, 5005, 5043, 5048–5049, 5054, 5058–5059, 5061, 5143, 5149, 5241, 5262, 5265–5270, 5278–5284, 5286–5287, 5332, 5345, 5440–5443, 5448, 5451, 5454, 5488, 5491, 5535, 5537, 5539, 5634, 5685, 5767, 5779, 5797, 5837–5838, 5842, 5844, 5878, 5882, 5884, 5886, 5888, 5934, 5938, 6037–6040, 6042, 6055, 6074, 6084, 6090, 6099–6101, 6104–6107, 6122, 6164, 6193, 6196, 6245–6248, 6251–6255, 6259, 6267, 6273, 6301, 6330, 6336–6337, 6388, 6408–6409, 6411, 6451–6452, 6459, 6464, 6470, 6483–6484, 6486, 6757–6759, 6778, 6791, 6803, 6831, 6991, 7006, 7071, 7101, 7139–7140, 7152, 7167–7168, 7170–7171, 7173–7174, 7176–7177, 7179–7182, 7184, 7186–7187, 7189, 7268–7269, 7281, 7325–7328, 7330, 7337–7338, 7498, 7553, 7588, 7608, 7610, 7711, 7871–7874, 7876–7878, 7937, 7956–7957, 7969, 7985, 8006–8007, 8009, 8026, 8113, 8127, 8130–8133, 8136, 8139, 8161–8164, 8261, 8280–8281, 8399, 8417, 8502, 8506–8507, 8521, 8524, 8537–8539, 8542, 8614, 8784–8785, 8865–8866, 8910–8911, 8913, 8916, 8927, 8933–8936, 8938, 8940, 8942–8943, 9059, 9184, 9198, 9201, 9405, 9414, 9480–9481, 9485, 9546–9549, 9551, 9573, 9585, 9681, 9717–9718, 9731, 9744–9749, 9765–9766, 9774–9775, 9788, 9796–9797, 9814–9815, 9829, 9839, 9855, 9866, 9874–9876, 9878, 9904, 9919, 9930, 9948–9949, 9952, 9970, 9973, 9988, 10002, 10008, 10023, 10040, 10052–10060, 10063–10064, 10066, 10081–10083, 10094, 10097, 10185, 10211, 10218, 10262, 10288–10289, 10332, 10334–10336, 10338, 10409, 10418, 10539, 10603, 10607–10608, 10699–10704, 10799–10802, 10892–10894, 10920, 10953, 11003–11004, 11009–11010, 11027, 11113–11115, 11134, 11342, 11458, 11482, 11505, 11530, 11537–11543, 11545, 11547, 11690, 11739–11740, 11742–11749, 11754–11756, 11758, 11760, 11861–11862, 11880, 11913–11914, 11918, 11958, 11961, 11963–11964, 11966, 11968, 11970, 11972–11975, 11977, 11979–11980, 11984–11986, 12019
Packs/Core/Integrations/CoreIOCs
   CoreIOCs.py3088173%53, 61, 63, 73, 89, 94, 111, 173–174, 235, 264, 294–301, 303–305, 307–308, 316, 337, 342, 351, 355–359, 363–364, 366, 370–372, 383, 396–407, 409, 433–441, 448–453, 459–468, 470–472
Packs/Core/Integrations/CortexCoreIR
   CortexCoreIR.py551278%36–39, 41, 44, 47, 54, 59, 62, 64, 108
Packs/CortexXDR/Integrations/CortexXDRIR
   CortexXDRIR.py6328586%59, 67, 71–73, 148–152, 154, 157, 160, 164, 232–236, 238, 245–248, 259, 262, 265, 271, 274, 300, 305, 313, 315, 318–322, 324, 407–412, 461, 499, 514–515, 532, 542, 602, 605, 632, 639, 641, 718–719, 721, 774, 955–957, 960, 963, 968, 1003, 1011, 1034, 1062–1063, 1114, 1123, 1125–1127, 1130, 1133–1134, 1171–1174, 1206, 1223
Packs/ctf01/Integrations/CortexXDRIRCTF
   CortexXDRIRCTF.py4644640%1–7, 10, 12–14, 16–18, 20, 37, 44, 52–57, 60–68, 71–72, 75–76, 79–80, 83–88, 91–98, 101, 109–121, 123–125, 128, 130, 134–138, 140, 143, 145, 153, 159, 163, 166–171, 173, 179–182, 184, 186, 208–209, 211, 216–217, 219–220, 224–225, 230–232, 238–239, 245–246, 251, 256–260, 263–264, 270–271, 277–278, 284–285, 291–292, 298–299, 301, 307, 309, 311, 319, 324, 331, 333, 335–340, 342, 344–345, 351, 358, 360–361, 367, 375, 377–378, 384, 387–389, 392, 400–402, 404, 408–410, 412, 415–416, 418–423, 426–427, 429, 432, 441–443, 445–447, 449–450, 453, 455–456, 545–552, 554, 556–557, 560, 562–563, 565, 567–568, 570, 572, 577, 580, 582–589, 591–595, 597, 599–607, 614, 616, 629, 632–636, 640–641, 646–648, 650, 652, 654, 656, 669, 671, 678, 681–685, 687, 690, 692, 695, 697, 704, 707–709, 711–713, 715–716, 718–720, 722–723, 725, 727–728, 730, 733–737, 739, 742, 746–751, 754–758, 767–768, 770–773, 775, 778–781, 783–784, 786, 789–791, 793, 795–797, 799, 801–804, 806, 809–811, 813–814, 817, 819, 823–824, 826–827, 829, 832, 835–836, 840, 843, 845–848, 850, 852, 858, 863, 868–869, 872–873, 875–877, 880, 883, 888, 894, 900, 1154, 1157, 1173–1174, 1178–1179, 1181–1182, 1184–1186, 1188–1189, 1194–1195, 1200, 1206–1208, 1210, 1212–1213, 1217–1218, 1220, 1222–1223, 1225–1227, 1233–1234, 1237–1238, 1240–1241, 1243–1245, 1247–1249, 1252, 1254–1255, 1257, 1259, 1261, 1264–1265, 1267–1268, 1273, 1278, 1281, 1283, 1291–1295, 1298, 1306, 1310, 2223–2226, 2228–2229, 2231, 2233, 2245, 2254–2256, 2258–2263, 2265, 2269, 2271, 2274, 2283, 2286–2291, 2293–2294, 2300, 2304, 2306, 2308, 2312
TOTAL7550157179% 

Tests Skipped Failures Errors Time
5294 88 💤 0 ❌ 0 🔥 4m 2s ⏱️

@maimorag maimorag changed the title fixed xpanse Fixed CortexCoreIR http_request Jul 3, 2024
@maimorag maimorag marked this pull request as ready for review July 3, 2024 12:35
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.34.24.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@maimorag maimorag requested a review from sapirshuker as a code owner July 4, 2024 05:53
@maimorag maimorag added the ForceMerge Forcing the merge of the PR despite the build status label Jul 4, 2024
@maimorag
Copy link
Contributor Author

maimorag commented Jul 4, 2024

The build fails on ״Max retries exceeded with url: /containers/reset (Caused by ConnectTimeoutError״ when running with multiple machine build since only one instance is available and it takes time until each machine can lock the integration. Also, the playbooks takes 30min.

https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/jobs/6870501 passed successfully.
@dantavori can you force merge?

@dantavori dantavori merged commit 1cdf9a8 into master Jul 4, 2024
17 of 18 checks passed
@dantavori dantavori deleted the xpanse-fix branch July 4, 2024 08:58
barryyosi-panw pushed a commit that referenced this pull request Jul 4, 2024
* fixed xpanse

* add RN

* fixed

* adding rn

* fix test

* fix test

* fix testcommonserver pyton

* fix unit tests and revert changes in demistomock

* add xplanatory docstring

* Bump pack from version Base to 1.34.24.

* adding memory threshold to incident enrichment

---------

Co-authored-by: sapirshuker <[email protected]>
Co-authored-by: Content Bot <[email protected]>
maimorag added a commit that referenced this pull request Jul 4, 2024
* fixed xpanse

* add RN

* fixed

* adding rn

* fix test

* fix test

* fix testcommonserver pyton

* fix unit tests and revert changes in demistomock

* add xplanatory docstring

* Bump pack from version Base to 1.34.24.

* adding memory threshold to incident enrichment

---------

Co-authored-by: sapirshuker <[email protected]>
Co-authored-by: Content Bot <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* fixed xpanse

* add RN

* fixed

* adding rn

* fix test

* fix test

* fix testcommonserver pyton

* fix unit tests and revert changes in demistomock

* add xplanatory docstring

* Bump pack from version Base to 1.34.24.

* adding memory threshold to incident enrichment

---------

Co-authored-by: sapirshuker <[email protected]>
Co-authored-by: Content Bot <[email protected]>
maimorag added a commit that referenced this pull request Oct 1, 2024
* adding command

* Ciac 10544 rasterize handle regression regarding integration option parameter (#34695)

* Added external last updated time incident field to the commontypes (#35004)

* Added external last updated time incident field to the commontypes

* RN

* fomated the incident field

* RN modified

* changed from verison

* RN

* commit

* unsearchable true

* HPE switch marketplace (#35201)

* Updated the MP to support only the right one

* Update rn

* Revert "Revert "[Marketplace Contribution] FTP"" (#35200)

* Revert "Revert "[Marketplace Contribution] FTP (#34659) (#35177)" (#35199)"

This reverts commit c34a2a4.

* added noqa

---------

Co-authored-by: RotemAmit <[email protected]>

* Update PaloAltoNetworks_Cortex_XDR_Incident_Sync_README.md (#35181)

* Update PaloAltoNetworks_Cortex_XDR_Incident_Sync_README.md

* Update Packs/CortexXDR/Playbooks/PaloAltoNetworks_Cortex_XDR_Incident_Sync_README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: Mai Morag <[email protected]>

* [SplunkPy] Update the README Troubleshooting (#35208)

* [SplunkPy] Update the Troubleshooting

* Update Packs/SplunkPy/Integrations/SplunkPy/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/SplunkPy/Integrations/SplunkPy/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: ShirleyDenkberg <[email protected]>

* Align dbot output context path and IN124 problematic packs (#35136)

* import problematic packs

* update

* changes

* import problematic packs

* update dockers

* update dockers

* added rns

* reverts

* update dockers

* cr fixes

* fix ComonServerPython docstring (#35197)

* fix ComonServerPython docstring

* RN

* Prevent changing infra files (#35209)

* demisto class for all (#35211)

* New pack for CVE-2024-6387 (#35220)

* New pack for CVE-2024-6387

* exclude-known-url

* adjust the playbook and pack readme

* adjust the playbook and pack readme

---------

Co-authored-by: Chanan Welt <[email protected]>

* Fix roles in common playbooks data collection task (#35133)

* Fixed an issue with the data collection tasks to send emails to the corresponding roles in XSIAM (Investigator) and XSOAR (Analyst).

* RN

* Removed administrator role from the data collection tasks

* udpated RN

* Recorded Future Intelligence Cloud CIAC - 10390 (#35030)

* Creating modeling rules

* Updating schema

* Removing url portal link

* Adding release notes and test data

* fixed test pb (#35221)

* Switch netutils (#34874)

* update image

* bump image

* Update Packs/ProofpointEmailSecurity/ReleaseNotes/1_0_2.md

* Update Packs/ProofpointEmailSecurity/Integrations/ProofpointEmailSecurityEventCollector/ProofpointEmailSecurityEventCollector.yml

* updated the classifier and layout of the qradar integration (#35222)

* updated the classifier and layout of the qradar integration

* added the release notes

* commit

* RN

* improved implementation of IsIncidentPartOfCampaign (#33954)

* improved implementation of IsIncidentPartOfCampaign

* was found

* docker update

* skip none string

* Zerofox/add cac data (#35227)

* Zerofox/add cac data (#35183)

* add compromised credentials command (#138)

* fix mypy check and tests

* Fix yml file format

* Add period to yaml description

* Include PR comments

- fix release notes comment
- add unit test
- format code

* update docker

* update RN

---------

Co-authored-by: Diego Ramirez R <[email protected]>
Co-authored-by: ipolishuk <[email protected]>

* Fixed CortexCoreIR http_request (#35206)

* fixed xpanse

* add RN

* fixed

* adding rn

* fix test

* fix test

* fix testcommonserver pyton

* fix unit tests and revert changes in demistomock

* add xplanatory docstring

* Bump pack from version Base to 1.34.24.

* adding memory threshold to incident enrichment

---------

Co-authored-by: sapirshuker <[email protected]>
Co-authored-by: Content Bot <[email protected]>

* Azure SQL Management - Client Credentials  (#35175)

* added client credentials flow - working

* updated readme and description

* changed to default value for token_retrieval_url

* created release notes and run pre commit

* changed redme and description after code review

* updated docker image

* changed some mistakes in readme

* changed some mistakes in discription

---------

Co-authored-by: noy <nodavidi.paloaltonetworks.com>

* Azure waf client credentials (#35182)

* changed yml file

* added client credentials to py

* added client credentials to py

* added release note

* changed readme and description for client credentials

* run pre commit

* updated docker image

* changed some mistakes in readme

* changed some mistakes in discription

---------

Co-authored-by: noy <nodavidi.paloaltonetworks.com>

* Update integration logo (#35112) (#35225)

updated integration logo to align with Prisma Cloud V2

Co-authored-by: epartington <[email protected]>
Co-authored-by: Danny Fried <[email protected]>

* Azure devops client credentials (#35034)

* changed the py file to match client credentials

* changed the yml file to match client cre4dentials

* changed the scope for client credentails

* changed the scope

* py

* getting 203 error from api

* made the final changes for client credentials

* changed description

* changed some description and added client credentials for README

* ran precommit and created release nores

* added global var for scope

* fixed pre commit

* made changes in readme and in description after doc review

* removed in description and in readme 'using cortex xsoar azure app'

* changed to default value for token_retrieval_url

* changed condition for scope

* changed test test_generate_login_urlplaybook to match the new scope

* changes cope global name

* updated docker image

* deleted the word Demisto - not relevant

* changed docker image and removed demisto word from description

---------

Co-authored-by: noy <nodavidi.paloaltonetworks.com>

* SplunkPy:get drilldown search in correct format (#35162)

* fix + RN + test

* RN

* fix ruff

* CR changes

* fix pre commit

* CR changes

* [MicrosoftAzureStorageApiModule] fixed token to start with '?' (#35223)

* fixed token to be with ?

* RN

* pre commit and docker

* fixed test AzureStorageTable_test.py

* fixed test AzureStorageQueue_test.py

* fixed test AzureStorageFileShare_test.py

* fixed test AzureStorageContainer_test.py

---------

Co-authored-by: okarkkatz <[email protected]>

* check

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix unit test

* pre-commit

* fix

* removing arg

* adding failed on status

* adding RN and docs

* unit test

* unit tests

* fix

* fix

* fix

* fix

* pre-commit

* Update Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py

Co-authored-by: EyalPintzov <[email protected]>

* Update Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py

Co-authored-by: EyalPintzov <[email protected]>

* add unit tests

* cr

* fix

* fix

* fixes

* fixes

* fix unit tests

* fix unit tests

* fix

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <[email protected]>

* fix

* fix

* fix

---------

Co-authored-by: ilaredo <[email protected]>
Co-authored-by: omerKarkKatz <[email protected]>
Co-authored-by: Shelly Tzohar <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: Menachem Weinfeld <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
Co-authored-by: Moshe Eichler <[email protected]>
Co-authored-by: dorschw <[email protected]>
Co-authored-by: Ben Melamed <[email protected]>
Co-authored-by: Chanan Welt <[email protected]>
Co-authored-by: Sasha Sokolovich <[email protected]>
Co-authored-by: ellopez777 <[email protected]>
Co-authored-by: Judah Schwartz <[email protected]>
Co-authored-by: content-bot <[email protected]>
Co-authored-by: Diego Ramirez R <[email protected]>
Co-authored-by: ipolishuk <[email protected]>
Co-authored-by: sapirshuker <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Co-authored-by: noydavidi <[email protected]>
Co-authored-by: epartington <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
Co-authored-by: Binat Ziser <[email protected]>
Co-authored-by: okarkkatz <[email protected]>
Co-authored-by: EyalPintzov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants