Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log message in olletools script #34488

Merged
merged 15 commits into from
May 26, 2024

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented May 22, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added a custom handler to fetch and print the error logs from oletools

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this May 22, 2024
@MosheEichler MosheEichler changed the title Add log message to olletools script Add log message in olletools script May 22, 2024
@ShirleyDenkberg
Copy link
Contributor

@thefrieddan1 @DeanArbel Doc review completed.

@MosheEichler MosheEichler requested a review from tkatzir May 23, 2024 09:19
Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Approved.

@MosheEichler MosheEichler merged commit d56b0ca into master May 26, 2024
16 of 17 checks passed
@MosheEichler MosheEichler deleted the add-kog-message-to-olletools-script branch May 26, 2024 10:16
maimorag pushed a commit that referenced this pull request May 27, 2024
* overwrite check method

* remove unnecessary import

* add log wrapper

* add log msg

* RN

* docker

* rn

* cr fix

* fix RN message

* capture all logs

* fix UT
maimorag pushed a commit that referenced this pull request May 29, 2024
* overwrite check method

* remove unnecessary import

* add log wrapper

* add log msg

* RN

* docker

* rn

* cr fix

* fix RN message

* capture all logs

* fix UT
aaron1535 pushed a commit that referenced this pull request Jun 9, 2024
* overwrite check method

* remove unnecessary import

* add log wrapper

* add log msg

* RN

* docker

* rn

* cr fix

* fix RN message

* capture all logs

* fix UT
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
* overwrite check method

* remove unnecessary import

* add log wrapper

* add log msg

* RN

* docker

* rn

* cr fix

* fix RN message

* capture all logs

* fix UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants