Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poking around and messing around with the Ancient Grain artifacts #33673

Closed

Conversation

rhermida
Copy link

@rhermida rhermida commented Apr 1, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Apr 1, 2024
@content-bot content-bot changed the base branch from master to contrib/rhermida_AncientGrain April 1, 2024 04:32
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @maimorag will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@maimorag
Copy link
Contributor

maimorag commented Apr 1, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @rhermida ,
Thank you for your contribution!
Please sign the CLA so I can start reviewing your contribution :)

@maimorag maimorag added the pending-contributor The PR is pending the response of its creator label Apr 1, 2024
@melamedbn melamedbn requested review from ssokolovich and removed request for melamedbn April 7, 2024 14:00
Copy link
Contributor

@ssokolovich ssokolovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhermida, Thanks for your contribution to our Marketplace.
Before we proceed, please sign your CLA so we can proceed forward with this Pull Request.

Adding below my notes on your work:

  1. Assuming that the TestMalware pack is indeed a Test of yours. Please mention if that is intentional or by mistake. In case it was added by mistake, please remove it from this PR.
  2. Added some comments on your contributed content- please review them. Feel free to mention me or reach out through our DFIR if you have any questions.

Moving forward (after the CLA), I would like to see a demo of this content.

"support": "community",
"currentVersion": "1.0.0",
"author": "Ramon Hermida",
"url": "https://live.paloaltonetworks.com/t5/cortex-xsoar-discussions/bd-p/Cortex_XSOAR_Discussions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this link related to the Pack info. Is that intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your incident type is missing running a playbook. Is that intentional?

"minH": 1,
"moved": false,
"name": "Ancient Grain Recipe",
"query": "PrintGrainRecipe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find this script in this PR, assuming it was not added yet. right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some sentences about the pack. It is always helpful to describe the pack's intention.

id: 38757eb4-8751-4b0b-8bd5-2d3c76396543
iscommand: true
name: Send Ancient Grain to ChatGPT for Recipe
script: Perplexity LLM Custom|||perplexity-send-prompt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't find this command in our repository - can you please share more details on this?

@maimorag
Copy link
Contributor

Hi @rhermida, we haven’t heard from you in a while.
Do you need any help with the pull request?

Please feel free to reach out to me here or on Slack.
Thanks again for contributing to our repo, hope to hear from you soon.

@maimorag
Copy link
Contributor

Hi @rhermida,
Thank you for your contribution.
I have not received a response from you in the last two weeks, so I will close your PR now.
Please feel free to re-open it when you are available to continue.
Thanks again.

@maimorag maimorag closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants