Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert output content as specified in yml file (#120) #33030

Conversation

figarrido
Copy link
Contributor

  • Add alert output content as specified in yml file

Also update command outputs in the yml file

  • Add release notes and update the app's version

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

* Add alert output content as specified in yml file

Also update command outputs in the yml file

* Add release notes and update the app's version
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 20, 2024
@content-bot content-bot changed the base branch from master to contrib/riskive_fix-mapping-outputs February 20, 2024 13:43
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Feb 20, 2024
Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution!
see my comment, and please make sure to sync your pr with master as it's failing a check stating gitlab might changed.

@merit-maita merit-maita removed the request for review from MLainer1 February 21, 2024 10:19
@merit-maita merit-maita added the pending-contributor The PR is pending the response of its creator label Feb 21, 2024
@figarrido
Copy link
Contributor Author

Hey @merit-maita!
I updated the release note as you suggested and also synced it with master, but the error is still there.

@merit-maita merit-maita added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 25, 2024
@content-bot
Copy link
Collaborator

content-bot commented Feb 25, 2024

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/849160

@merit-maita merit-maita self-requested a review February 25, 2024 09:47
@merit-maita merit-maita added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Feb 25, 2024
@merit-maita merit-maita merged commit fb6c3a5 into demisto:contrib/riskive_fix-mapping-outputs Feb 25, 2024
26 of 32 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

merit-maita added a commit that referenced this pull request Feb 26, 2024
…3092)

* Add alert output content as specified in yml file (#120)

* Add alert output content as specified in yml file

Also update command outputs in the yml file

* Add release notes and update the app's version

* Update integration readme

* Update Packs/ZeroFox/ReleaseNotes/1_2_8.md



---------

Co-authored-by: Felipe Garrido <[email protected]>
Co-authored-by: merit-maita <[email protected]>
@figarrido figarrido deleted the fix-mapping-outputs branch February 26, 2024 13:30
rundssoar pushed a commit to rundssoar/content that referenced this pull request Feb 28, 2024
…sto#33030) (demisto#33092)

* Add alert output content as specified in yml file (demisto#120)

* Add alert output content as specified in yml file

Also update command outputs in the yml file

* Add release notes and update the app's version

* Update integration readme

* Update Packs/ZeroFox/ReleaseNotes/1_2_8.md



---------

Co-authored-by: Felipe Garrido <[email protected]>
Co-authored-by: merit-maita <[email protected]>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
…3092)

* Add alert output content as specified in yml file (#120)

* Add alert output content as specified in yml file

Also update command outputs in the yml file

* Add release notes and update the app's version

* Update integration readme

* Update Packs/ZeroFox/ReleaseNotes/1_2_8.md



---------

Co-authored-by: Felipe Garrido <[email protected]>
Co-authored-by: merit-maita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. TIM Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants