Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpyCloud Enterprise Protection initial commit #32732

Conversation

amshamah419
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

guytamir10 and others added 12 commits February 6, 2024 11:00
* added a modeling rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule

* added a parsing rule
Edit the file to remove duplication of command names in the right pane.
* save

* save no exit_code

* save not fail on test-modeling-rules

* remove ciscoasa changes
* Updated Metadata Of Pack ExpanseV2

* Added release notes to pack ExpanseV2

* Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update
Edit the file to remove duplication of command names in the right pane.
* Updated Metadata Of Pack ExpanseV2

* Added release notes to pack ExpanseV2

* Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update
@amshamah419 amshamah419 self-assigned this Feb 6, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 6 committers have signed the CLA.

✅ ShirleyDenkberg
✅ amshamah419
✅ daryakoval
✅ content-bot
❌ guytamir10
❌ loginsoft-integrations
You have signed the CLA already but the status is still pending? Let us recheck it.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR labels Feb 6, 2024
@content-bot content-bot changed the base branch from master to contrib/VukaHeavyIndustries_spycloudenterpriseprotection-2 February 6, 2024 09:16
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yucohen will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@amshamah419 amshamah419 removed the request for review from yucohen February 6, 2024 09:18
@amshamah419 amshamah419 added Partner Contribution Form Filled Whether contribution form filled or not. Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 6, 2024
@amshamah419
Copy link
Contributor Author

@loginsoft-integrations I got this PR setup since the other was getting messy. Please review the errors found in the validation. It looks like the mapper and layout are looking for a field which doesn't exist.

[2024-02-06 09:34:44,839] [ERROR] /home/circleci/project/Packs/SpyCloudEnterpriseProtection/Layouts/layoutscontainer-SpyCloudBreachLayout.json: [GR103] - Content item 'SpyCloud Breach Layout' using content items: 'spycoudseverity' which cannot be found in the repository.

[2024-02-06 09:34:44,840] [ERROR] /home/circleci/project/Packs/SpyCloudEnterpriseProtection/Layouts/layoutscontainer-SpyCloudMalwareLayout.json: [GR103] - Content item 'SpyCloud Malware Layout' using content items: 'spycoudseverity' which cannot be found in the repository.

[2024-02-06 09:34:44,840] [ERROR] /home/circleci/project/Packs/SpyCloudEnterpriseProtection/Classifiers/classifier-SpyCloud_Mapper.json: [GR103] - Content item 'SpyCloud - Incoming Mapper' using content items: 'SpyCloud User Hostname' which cannot be found in the repository.

Once we are passing, then the merge should be fairly straightforward

@loginsoft-integrations
Copy link

@loginsoft-integrations I got this PR setup since the other was getting messy. Please review the errors found in the validation. It looks like the mapper and layout are looking for a field which doesn't exist.

[2024-02-06 09:34:44,839] [ERROR] /home/circleci/project/Packs/SpyCloudEnterpriseProtection/Layouts/layoutscontainer-SpyCloudBreachLayout.json: [GR103] - Content item 'SpyCloud Breach Layout' using content items: 'spycoudseverity' which cannot be found in the repository.

[2024-02-06 09:34:44,840] [ERROR] /home/circleci/project/Packs/SpyCloudEnterpriseProtection/Layouts/layoutscontainer-SpyCloudMalwareLayout.json: [GR103] - Content item 'SpyCloud Malware Layout' using content items: 'spycoudseverity' which cannot be found in the repository.

[2024-02-06 09:34:44,840] [ERROR] /home/circleci/project/Packs/SpyCloudEnterpriseProtection/Classifiers/classifier-SpyCloud_Mapper.json: [GR103] - Content item 'SpyCloud - Incoming Mapper' using content items: 'SpyCloud User Hostname' which cannot be found in the repository.

Once we are passing, then the merge should be fairly straightforward

Hi @amshamah419
changes done

@amshamah419
Copy link
Contributor Author

@loginsoft-integrations Since I pushed the commits, I need another dev to approve so I can continue. I've asked Yuval to help us out and afterwards I'll handle the internal PR

@amshamah419
Copy link
Contributor Author

@loginsoft-integrations You guys have signed the CLA yes? Just trying to see if this will just require a force merge so we can progress it.

@RamboV
Copy link
Contributor

RamboV commented Feb 8, 2024

@loginsoft-integrations You guys have signed the CLA yes? Just trying to see if this will just require a force merge so we can progress it.

Hi @amshamah419
For this new PR, we completed the signing of the CLA earlier today.

@yuvalbenshalom yuvalbenshalom merged commit 2900234 into demisto:contrib/VukaHeavyIndustries_spycloudenterpriseprotection-2 Feb 8, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.