Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

31078 misp #32237

Merged
merged 50 commits into from
Jan 31, 2024
Merged

31078 misp #32237

merged 50 commits into from
Jan 31, 2024

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jan 16, 2024

Status

  • In Progress

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-31078

Description

Adding a limit to fetch indicators command

maimorag and others added 17 commits December 14, 2023 15:48
Edit the file to remove duplication of command names in the right pane.
* save

* save no exit_code

* save not fail on test-modeling-rules

* remove ciscoasa changes
* Updated Metadata Of Pack ExpanseV2

* Added release notes to pack ExpanseV2

* Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update
* Updated Metadata Of Pack ExpanseV2

* Added release notes to pack ExpanseV2

* Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update
Copy link

github-actions bot commented Jan 16, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedMISP/Integrations/FeedMISP
   FeedMISP.py1895869%181–186, 272, 287, 366, 368–369, 372, 380, 388–389, 392, 415, 418, 430, 454–455, 467–475, 477–483, 490, 492, 531–537, 539–541, 549–554, 557, 559–560
TOTAL1895869% 

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 1.895s ⏱️

@maimorag maimorag marked this pull request as ready for review January 23, 2024 10:09
@maimorag maimorag requested review from eyalpalo and removed request for eyalpalo January 25, 2024 16:24
@maimorag maimorag requested a review from eyalpalo January 28, 2024 07:36
@maimorag maimorag requested a review from eyalpalo January 28, 2024 08:56
@maimorag maimorag requested a review from eyalpalo January 28, 2024 14:54
@maimorag maimorag merged commit 89f16e9 into master Jan 31, 2024
16 checks passed
@maimorag maimorag deleted the 31078-misp branch January 31, 2024 08:32
yasta5 pushed a commit that referenced this pull request Feb 4, 2024
* adding debug to indicators

* adding the unify yml

* fixed custom version

* Update README.md (#23810)

Edit the file to remove duplication of command names in the right pane.

* Modeling rules fixes (#24259)

* save

* save no exit_code

* save not fail on test-modeling-rules

* remove ciscoasa changes

* Update Docker Image To demisto/chromium  (#24291)

* Updated Metadata Of Pack ExpanseV2

* Added release notes to pack ExpanseV2

* Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update

* Update Docker Image To demisto/chromium  (#24291)

* Updated Metadata Of Pack ExpanseV2

* Added release notes to pack ExpanseV2

* Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update

* release note

* Delete .gitlab/ci/on-push.yml

* Delete Packs/Auditd/ModelingRules/Auditd_1_3/Auditd_1_3_testdata.json

* try

* fix

* fix

* adding limit to fetch indicators

* adding to docs

* fixing limit

* fix val

* custom integration

* fix cr

* testing

* fix pre-commit

* Update Packs/FeedMISP/ReleaseNotes/1_0_31.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* changes fix

* limit and page size together

* fix

* fix fetch

* fix rl

* adding unit tests

* fix doc string

* fix

* not to push

* cr notes

* cr notes ream me

* cr notes - fix docstring test

* cr notes - fix command, yml, timestamp

* cr notes - fix duplicates

* pre commit

* pre commit fix

* cr notes

* fix unit test

* Apply suggestions from code review

Co-authored-by: EyalPintzov <[email protected]>

---------

Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: Darya Koval <[email protected]>
Co-authored-by: content-bot <[email protected]>
Co-authored-by: EyalPintzov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants