Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YR-Fix-documentation/FeedRecordeduture/XSUP-29069 #31015

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Nov 21, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

relates: https://jira-dc.paloaltonetworks.com/browse/XSUP-29069

Description

  • Added documentation to the user to avoid receiving 100k indicators per instance, since we are limited by the API to have only 100k indicators active.

  • change the default expiration method to be by indicator type, instead of "when removed from feed" to gain a little more time before those extra indicators expire.
    Note:
    The "extend Docker timeout" in the name of the branch was not implemented in the end, so please disregard it.

Must have

  • Tests
  • Documentation

@RosenbergYehuda RosenbergYehuda changed the title YR-Extend-docker-timeout-and-fix-documentation/FeedRecordeduture/XSUP-29069 YR-Fix-documentation/FeedRecordeduture/XSUP-29069 Nov 22, 2023
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, please fix the one tiny issue and we can move forward.

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ShirleyDenkberg
Copy link
Contributor

@JasBeilin Doc review completed.

Co-authored-by: ShirleyDenkberg <[email protected]>
@RosenbergYehuda RosenbergYehuda merged commit e6dd668 into master Nov 26, 2023
13 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR-Extend-docker-timeout-and-fix-documentation/FeedRecordeduture/XSUP-29069 branch November 26, 2023 10:56
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* code changes

* docs

* more docs

* Troubleshooting

* RN

* RN

* test

* ignore docker timeout

* RN

* RN

* Apply suggestions from Shirley

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants