-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YR-Fix-documentation/FeedRecordeduture/XSUP-29069 #31015
Merged
RosenbergYehuda
merged 15 commits into
master
from
YR-Extend-docker-timeout-and-fix-documentation/FeedRecordeduture/XSUP-29069
Nov 26, 2023
Merged
YR-Fix-documentation/FeedRecordeduture/XSUP-29069 #31015
RosenbergYehuda
merged 15 commits into
master
from
YR-Extend-docker-timeout-and-fix-documentation/FeedRecordeduture/XSUP-29069
Nov 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd-fix-documentation/FeedRecordeduture/XSUP-29069
…nd-fix-documentation/FeedRecordeduture/XSUP-29069
…nd-fix-documentation/FeedRecordeduture/XSUP-29069
RosenbergYehuda
changed the title
YR-Extend-docker-timeout-and-fix-documentation/FeedRecordeduture/XSUP-29069
YR-Fix-documentation/FeedRecordeduture/XSUP-29069
Nov 22, 2023
JasBeilin
requested changes
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, please fix the one tiny issue and we can move forward.
…nd-fix-documentation/FeedRecordeduture/XSUP-29069
JasBeilin
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Packs/FeedRecordedFuture/Integrations/FeedRecordedFuture/README.md
Outdated
Show resolved
Hide resolved
Packs/FeedRecordedFuture/Integrations/FeedRecordedFuture/README.md
Outdated
Show resolved
Hide resolved
@JasBeilin Doc review completed. |
Co-authored-by: ShirleyDenkberg <[email protected]>
RosenbergYehuda
deleted the
YR-Extend-docker-timeout-and-fix-documentation/FeedRecordeduture/XSUP-29069
branch
November 26, 2023 10:56
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* code changes * docs * more docs * Troubleshooting * RN * RN * test * ignore docker timeout * RN * RN * Apply suggestions from Shirley Co-authored-by: ShirleyDenkberg <[email protected]> --------- Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
relates: https://jira-dc.paloaltonetworks.com/browse/XSUP-29069
Description
Added documentation to the user to avoid receiving 100k indicators per instance, since we are limited by the API to have only 100k indicators active.
change the default expiration method to be by indicator type, instead of "when removed from feed" to gain a little more time before those extra indicators expire.
Note:
The "extend Docker timeout" in the name of the branch was not implemented in the end, so please disregard it.
Must have