Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert jira issues - removing backward compatible, adding links #30714

Merged
merged 17 commits into from
Nov 8, 2023
Merged

convert jira issues - removing backward compatible, adding links #30714

merged 17 commits into from
Nov 8, 2023

Conversation

kobymeir
Copy link
Contributor

@kobymeir kobymeir commented Nov 7, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

convert jira issues

  • removing backward compatible
  • adding links to jira tickets in gitlab
  • adding the host running the pipeline to the slack message
  • showing playbooks and modeling errors as warning if all the tickets were update/created in jira.

@kobymeir kobymeir self-assigned this Nov 7, 2023
@kobymeir kobymeir changed the title convert jira issues - removing backward compatible convert jira issues - removing backward compatible, adding links Nov 7, 2023
@kobymeir kobymeir marked this pull request as ready for review November 8, 2023 04:54
@kobymeir kobymeir requested review from sapirshuker and removed request for yucohen November 8, 2023 04:55
@kobymeir kobymeir removed the request for review from michal-dagan November 8, 2023 04:55
tkatzir
tkatzir approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!
Approved, with some comments.

Tests/scripts/test_modeling_rule_report.py Outdated Show resolved Hide resolved
Tests/scripts/test_modeling_rule_report.py Show resolved Hide resolved
Tests/scripts/gitlab_slack_notifier.py Show resolved Hide resolved
Tests/scripts/gitlab_slack_notifier.py Outdated Show resolved Hide resolved
Tests/scripts/gitlab_slack_notifier.py Outdated Show resolved Hide resolved
Tests/scripts/test_playbooks_report.py Outdated Show resolved Hide resolved
Tests/scripts/test_playbooks_report.py Show resolved Hide resolved
@kobymeir kobymeir merged commit 125b5f5 into master Nov 8, 2023
13 checks passed
@kobymeir kobymeir deleted the convert-jira-tickets branch November 8, 2023 15:45
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@kobymeir
convert jira issues - removing backward compatible, adding links (#30714
908721b 
)

convert jira issues - removing backward compatible, adding links #30714
israelpoli pushed a commit that referenced this pull request May 15, 2024
@kobymeir
convert jira issues - removing backward compatible, adding links (#30714
16f39ca 
)

convert jira issues - removing backward compatible, adding links #30714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkatzir tkatzir tkatzir approved these changes

@sapirshuker sapirshuker Awaiting requested review from sapirshuker

Assignees

@kobymeir kobymeir

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobymeir @tkatzir