Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting prepare-testing-bucket output to be per server type #30509

Merged
merged 24 commits into from
Nov 6, 2023
Merged

Splitting prepare-testing-bucket output to be per server type #30509

merged 24 commits into from
Nov 6, 2023

Conversation

kobymeir
Copy link
Contributor

@kobymeir kobymeir commented Oct 30, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Splitting prepare-testing-bucket output to be per server type

https://github.com/demisto/content-private/pull/692

@kobymeir kobymeir requested a review from omerKarkKatz October 30, 2023 07:07
@kobymeir kobymeir self-assigned this Oct 30, 2023
@kobymeir kobymeir mentioned this pull request Oct 31, 2023
Closed
@demisto demisto deleted a comment from guardrails bot Oct 31, 2023
@kobymeir kobymeir marked this pull request as ready for review November 2, 2023 08:53
@kobymeir kobymeir removed the request for review from yaakovpraisler November 2, 2023 08:54
omerKarkKatz
omerKarkKatz reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment relating to content private

Tests/Marketplace/download_private_id_set.py Outdated Show resolved Hide resolved
omerKarkKatz
omerKarkKatz approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@kobymeir kobymeir merged commit 6ec0531 into master Nov 6, 2023
13 checks passed
@kobymeir kobymeir deleted the split-prepeare-testing-bucket-output-per-server-type branch November 6, 2023 13:06
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@kobymeir
Splitting prepare-testing-bucket output to be per server type (#30509)
e833314 
Splitting prepare-testing-bucket output to be per server type #30509
israelpoli pushed a commit that referenced this pull request May 15, 2024
@kobymeir
Splitting prepare-testing-bucket output to be per server type (#30509)
e094072 
Splitting prepare-testing-bucket output to be per server type #30509
israelpoli pushed a commit that referenced this pull request May 15, 2024
@kobymeir
Splitting prepare-testing-bucket output to be per server type (#30509)
4cad140 
Splitting prepare-testing-bucket output to be per server type #30509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerKarkKatz omerKarkKatz omerKarkKatz approved these changes

Assignees

@kobymeir kobymeir

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobymeir @omerKarkKatz