Fix cyberark-pas-account-add (cyberark) #30294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorschw
approved these changes
Oct 18, 2023
| @@ -361,7 +379,7 @@ def add_account(self, | |||
| safe_name: str, | |||
| password: str, | |||
| secret_type: str, | |||
| properties: str, | |||
| properties: dict, | |||
There was a problem hiding this comment.
Suggested change
| properties: dict, | |
| properties: dict | str, |
right?
There was a problem hiding this comment.
It must be a dict, and the order_properties_to_dict function forces it to be a dict
(But following the comment I changed the typing for the add_account_command function)
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* commit * add UT and RN * corrections * Fix DS108 and update Docker * correction comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-28945
Description
A few sentences describing the overall goals of the pull request's commits.
Must have