[ASM] - Expander - Standardize enrichment names in asmsystemids grid field (4819 & 5508) #29098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ShirleyDenkberg <[email protected]>
Updated asmsystemids to a new standard for consistency. Create new tests for all of our enrichment playbook using asmsystemids, to check if keys of asmsystemids are valid.
- Add test for tenable enrichment playbook for asmsystemids - Update Rapid7 OS field
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/BigEasyJ_EXPANDR-4819
johnnywilkes
suggested changes
Aug 23, 2023
Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_AWS_Enrichment.yml
Outdated
Show resolved
Hide resolved
MichaelYochpaz
added
the
pending-contributor
johnnywilkes
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
@BigEasyJ , approved. You might have to change your tested based on pre-commit tests but not sure: https://github.com/demisto/content/actions/runs/5996766820/job/16261891990?pr=29098
|
@MichaelYochpaz / @melamedbn , this is approved form Xpanse side. Please merge when possible |
- Updated comment in helper for conftest.py conflict
|
Made changes suggested by @MichaelYochpaz, however I see precommit failing due to not find the existing file path |
MichaelYochpaz
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6192249 |
- New class in helper for loading yaml files as a dictionary - Updated test files to use a base path and new class object
MichaelYochpaz
approved these changes
Aug 31, 2023
Merged
5 tasks
MichaelYochpaz
pushed a commit
that referenced
this pull request
Aug 31, 2023
…field (4819 & 5508) (#29098) (#29357) * asmcloud * collection, notification and privIP * remediation, servicedetection and systemids * tags, serviceowner, summary * GridFieldSetup * automations * fixed some misses * update playbook names for testing * update parent README * remove temp naming for testing * fix parent and RN * docker and pre-commit * update RN * fix typo * Apply suggestions from code review * added Shirleys change to playbook inputs * Update asmsystemids and created playbook tests. Updated asmsystemids to a new standard for consistency. Create new tests for all of our enrichment playbook using asmsystemids, to check if keys of asmsystemids are valid. * Update asmsystemids in tenable playbook - Add test for tenable enrichment playbook for asmsystemids - Update Rapid7 OS field * Update release notes * Formatting for tests files * Revert AWS enrichment version * Remove prints from tests unless needed in future * Update playbooks with bugs fix commit Applied changes from 3d397fa. * Add S3 task and update PNGs * Update AWS enrichment and test * EXPANDR-5782 * Fix Qualys playbook description * Update Set ASM system IDs type description * Update documentation and names of tests * Move playbook tests to new location - Updated comment in helper for conftest.py conflict * Update test files and helper - New class in helper for loading yaml files as a dictionary - Updated test files to use a base path and new class object * Fix formatting for pre-commit --------- Co-authored-by: John <[email protected]> Co-authored-by: jwilkes <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
moishce
pushed a commit
that referenced
this pull request
Sep 14, 2023
…field (4819 & 5508) (#29098) (#29357) * asmcloud * collection, notification and privIP * remediation, servicedetection and systemids * tags, serviceowner, summary * GridFieldSetup * automations * fixed some misses * update playbook names for testing * update parent README * remove temp naming for testing * fix parent and RN * docker and pre-commit * update RN * fix typo * Apply suggestions from code review * added Shirleys change to playbook inputs * Update asmsystemids and created playbook tests. Updated asmsystemids to a new standard for consistency. Create new tests for all of our enrichment playbook using asmsystemids, to check if keys of asmsystemids are valid. * Update asmsystemids in tenable playbook - Add test for tenable enrichment playbook for asmsystemids - Update Rapid7 OS field * Update release notes * Formatting for tests files * Revert AWS enrichment version * Remove prints from tests unless needed in future * Update playbooks with bugs fix commit Applied changes from 3d397fa. * Add S3 task and update PNGs * Update AWS enrichment and test * EXPANDR-5782 * Fix Qualys playbook description * Update Set ASM system IDs type description * Update documentation and names of tests * Move playbook tests to new location - Updated comment in helper for conftest.py conflict * Update test files and helper - New class in helper for loading yaml files as a dictionary - Updated test files to use a base path and new class object * Fix formatting for pre-commit --------- Co-authored-by: John <[email protected]> Co-authored-by: jwilkes <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
…field (4819 & 5508) (demisto#29098) (demisto#29357) * asmcloud * collection, notification and privIP * remediation, servicedetection and systemids * tags, serviceowner, summary * GridFieldSetup * automations * fixed some misses * update playbook names for testing * update parent README * remove temp naming for testing * fix parent and RN * docker and pre-commit * update RN * fix typo * Apply suggestions from code review * added Shirleys change to playbook inputs * Update asmsystemids and created playbook tests. Updated asmsystemids to a new standard for consistency. Create new tests for all of our enrichment playbook using asmsystemids, to check if keys of asmsystemids are valid. * Update asmsystemids in tenable playbook - Add test for tenable enrichment playbook for asmsystemids - Update Rapid7 OS field * Update release notes * Formatting for tests files * Revert AWS enrichment version * Remove prints from tests unless needed in future * Update playbooks with bugs fix commit Applied changes from 3d397fa. * Add S3 task and update PNGs * Update AWS enrichment and test * EXPANDR-5782 * Fix Qualys playbook description * Update Set ASM system IDs type description * Update documentation and names of tests * Move playbook tests to new location - Updated comment in helper for conftest.py conflict * Update test files and helper - New class in helper for loading yaml files as a dictionary - Updated test files to use a base path and new class object * Fix formatting for pre-commit --------- Co-authored-by: John <[email protected]> Co-authored-by: jwilkes <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
…field (4819 & 5508) (#29098) (#29357) * asmcloud * collection, notification and privIP * remediation, servicedetection and systemids * tags, serviceowner, summary * GridFieldSetup * automations * fixed some misses * update playbook names for testing * update parent README * remove temp naming for testing * fix parent and RN * docker and pre-commit * update RN * fix typo * Apply suggestions from code review * added Shirleys change to playbook inputs * Update asmsystemids and created playbook tests. Updated asmsystemids to a new standard for consistency. Create new tests for all of our enrichment playbook using asmsystemids, to check if keys of asmsystemids are valid. * Update asmsystemids in tenable playbook - Add test for tenable enrichment playbook for asmsystemids - Update Rapid7 OS field * Update release notes * Formatting for tests files * Revert AWS enrichment version * Remove prints from tests unless needed in future * Update playbooks with bugs fix commit Applied changes from fda45d1. * Add S3 task and update PNGs * Update AWS enrichment and test * EXPANDR-5782 * Fix Qualys playbook description * Update Set ASM system IDs type description * Update documentation and names of tests * Move playbook tests to new location - Updated comment in helper for conftest.py conflict * Update test files and helper - New class in helper for loading yaml files as a dictionary - Updated test files to use a base path and new class object * Fix formatting for pre-commit --------- Co-authored-by: John <[email protected]> Co-authored-by: jwilkes <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Description
Updating the
typefield values whereasmsystemidsis set throughout playbooks to use standardized values.Must have