WildFire update for MAEC report output #27766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WildFire update for MAEC report output updating release notes updating docker images adding contributor file adding missing readme json file structure was incorrect, updating the output format for valid json string * updating known words and syntax updating known words and syntax in readme file * Update Palo_Alto_Networks_WildFire_v2.py updated as per comments from @thefrieddan1 * Apply suggestions from code review Tech doc review. Co-authored-by: ShirleyDenkberg <[email protected]> * Revert changes to RN. --------- Co-authored-by: Danny Fried <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
content-bot
added
Contribution
thefrieddan1
approved these changes
Jun 27, 2023
thefrieddan1
deleted the
contrib/epartington_epartington-wildfire-maec-downloadformatfix
branch
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* WildFire update for MAEC report output (#27455) * WildFire update for MAEC report output updating release notes updating docker images adding contributor file adding missing readme json file structure was incorrect, updating the output format for valid json string * updating known words and syntax updating known words and syntax in readme file * Update Palo_Alto_Networks_WildFire_v2.py updated as per comments from @thefrieddan1 * Apply suggestions from code review Tech doc review. Co-authored-by: ShirleyDenkberg <[email protected]> * Revert changes to RN. --------- Co-authored-by: Danny Fried <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> * Update docker image. Update RN. --------- Co-authored-by: epartington <[email protected]> Co-authored-by: Danny Fried <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* WildFire update for MAEC report output (demisto#27455) * WildFire update for MAEC report output updating release notes updating docker images adding contributor file adding missing readme json file structure was incorrect, updating the output format for valid json string * updating known words and syntax updating known words and syntax in readme file * Update Palo_Alto_Networks_WildFire_v2.py updated as per comments from @thefrieddan1 * Apply suggestions from code review Tech doc review. Co-authored-by: ShirleyDenkberg <[email protected]> * Revert changes to RN. --------- Co-authored-by: Danny Fried <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> * Update docker image. Update RN. --------- Co-authored-by: epartington <[email protected]> Co-authored-by: Danny Fried <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@epartington
updating release notes
updating docker images
adding contributor file
adding missing readme
json file structure was incorrect, updating the output format for valid json string
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Fix a command output wildfire-get-report using format=maec that was not JSON formatted, now the returned file is valid JSON structure
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have