-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove two deprecated packs from Common Widgets #27694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshunim
changed the title
Xsoar-Ng - Widgets - Scripts - hidden
Xsoar-Ng - Widgets - Scripts - hide
Jun 25, 2023
rshunim
changed the title
Xsoar-Ng - Widgets - Scripts - hide
Xsoar-Ng - Widgets - Scripts - Hide
Jun 25, 2023
dorschw
reviewed
Jun 25, 2023
dorschw
approved these changes
Jun 25, 2023
rshunim
changed the title
Xsoar-Ng - Widgets - Scripts - Hide
Remove two deprecated packs from Common Widgets
Jun 26, 2023
yuvalbenshalom
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment
Co-authored-by: yuvalbenshalom <[email protected]>
11 tasks
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* hide widgets * BC * [known_words] * remove those 2 packs * Update Packs/CommonWidgets/ReleaseNotes/1_2_23.json Co-authored-by: dorschw <[email protected]> * RN * RN * Update Packs/CommonWidgets/ReleaseNotes/1_2_23.md Co-authored-by: yuvalbenshalom <[email protected]> --------- Co-authored-by: dorschw <[email protected]> Co-authored-by: yuvalbenshalom <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* hide widgets * BC * [known_words] * remove those 2 packs * Update Packs/CommonWidgets/ReleaseNotes/1_2_23.json Co-authored-by: dorschw <[email protected]> * RN * RN * Update Packs/CommonWidgets/ReleaseNotes/1_2_23.md Co-authored-by: yuvalbenshalom <[email protected]> --------- Co-authored-by: dorschw <[email protected]> Co-authored-by: yuvalbenshalom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CRTX-86101
Description
The two packs are deprecated.
Since they still appear in the dashboard editor, I tried to hide them by adding "enabled:false" to the yml file, but it didn't work, so we removed them.