Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two deprecated packs from Common Widgets #27694

Merged
merged 14 commits into from
Jun 26, 2023
Merged

Conversation

rshunim
Copy link
Contributor

@rshunim rshunim commented Jun 25, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CRTX-86101

Description

The two packs are deprecated.
Since they still appear in the dashboard editor, I tried to hide them by adding "enabled:false" to the yml file, but it didn't work, so we removed them.

@rshunim rshunim requested a review from dorschw June 25, 2023 09:23
@rshunim rshunim self-assigned this Jun 25, 2023
@rshunim rshunim changed the title Xsoar-Ng - Widgets - Scripts - hidden Xsoar-Ng - Widgets - Scripts - hide Jun 25, 2023
@rshunim rshunim changed the title Xsoar-Ng - Widgets - Scripts - hide Xsoar-Ng - Widgets - Scripts - Hide Jun 25, 2023
@rshunim rshunim changed the title Xsoar-Ng - Widgets - Scripts - Hide Remove two deprecated packs from Common Widgets Jun 26, 2023
@rshunim rshunim requested a review from dorschw June 26, 2023 09:03
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

Packs/CommonWidgets/ReleaseNotes/1_2_23.md Outdated Show resolved Hide resolved
@yuvalbenshalom yuvalbenshalom merged commit 69cee8b into master Jun 26, 2023
@yuvalbenshalom yuvalbenshalom deleted the widgets_NG branch June 26, 2023 14:05
@rshunim rshunim mentioned this pull request Jun 27, 2023
11 tasks
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* hide widgets

* BC

* [known_words]

* remove those 2 packs

* Update Packs/CommonWidgets/ReleaseNotes/1_2_23.json

Co-authored-by: dorschw <[email protected]>

* RN

* RN

* Update Packs/CommonWidgets/ReleaseNotes/1_2_23.md

Co-authored-by: yuvalbenshalom <[email protected]>

---------

Co-authored-by: dorschw <[email protected]>
Co-authored-by: yuvalbenshalom <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* hide widgets

* BC

* [known_words]

* remove those 2 packs

* Update Packs/CommonWidgets/ReleaseNotes/1_2_23.json

Co-authored-by: dorschw <[email protected]>

* RN

* RN

* Update Packs/CommonWidgets/ReleaseNotes/1_2_23.md

Co-authored-by: yuvalbenshalom <[email protected]>

---------

Co-authored-by: dorschw <[email protected]>
Co-authored-by: yuvalbenshalom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants