Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft Align credentials stores -part 23 #27684

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Microsoft Align credentials stores -part 23 #27684

merged 9 commits into from
Jun 26, 2023

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jun 24, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue
Fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-7170

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag maimorag requested a review from Shellyber June 25, 2023 14:33
@maimorag
Copy link
Contributor Author

maimorag commented Jun 25, 2023 •
edited
Loading

Adding changes besides aligning credentials in MicrosoftManagementActivity:

  1. Changed the order between "Token or Tenant ID" and "Key or Client Secret" (now "Key or Client Secret" is below "Token or Tenant ID").
  2. In "Use a self-deployed Azure application", I changed the required to false

Jira ticket

@maimorag maimorag merged commit f353620 into master Jun 26, 2023
@maimorag maimorag deleted the align_credentials_stores_part_23 branch June 26, 2023 09:37
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
@maimorag @MosheEichler
Microsoft Align credentials stores -part 23 (#27684)
369d886 
* Microsoft Align credentials stores -part 23

* fix lint

* RL

* fix

* fix

* fix

* fix rl

* fix client bug for  for Michal's request

* fixes
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
@maimorag @xsoar-bot
Microsoft Align credentials stores -part 23 (demisto#27684)
c956be0 
* Microsoft Align credentials stores -part 23

* fix lint

* RL

* fix

* fix

* fix

* fix rl

* fix client bug for  for Michal's request

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shellyber Shellyber Shellyber approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maimorag @Shellyber