Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marketplace Contribution] ExtraHop Reveal(x) - Content Pack Update #27587

Merged
merged 8 commits into from
Jun 27, 2023
Merged

[Marketplace Contribution] ExtraHop Reveal(x) - Content Pack Update #27587

merged 8 commits into from
Jun 27, 2023

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@RFC1918-hub

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Jun 20, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_RFC1918-hub-contrib-ExtraHop June 20, 2023 10:32
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @thefrieddan1 will very shortly look over your proposed changes.

@content-bot content-bot requested a review from thefrieddan1 June 20, 2023 10:32
thefrieddan1
thefrieddan1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@thefrieddan1 thefrieddan1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thank you for your contribution we appreciate your effort, I reviewed the content in the PR and would like to provide some feedback:
For XSOAR supported packs like this, This is a Partner pack. Contribution made by Partner.
It is expected to cover all with unit tests.

Thanks

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RFC1918-hub
Copy link
Contributor

Hi, Thank you for your contribution we appreciate your effort, I reviewed the content in the PR and would like to provide some feedback: For XSOAR supported packs like this, It is expected to cover all with unit tests. I do not see an added unit test which covers the ticket_severity

Thanks

Hi @thefrieddan1 I'm not familiar with unit test? Could you please elaborate?

@thefrieddan1 thefrieddan1 added Partner Partner Support Level Indicates that the contribution is for Partner supported pack labels Jun 25, 2023
@thefrieddan1 thefrieddan1 added docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jun 25, 2023
@content-bot
Copy link
Collaborator

content-bot commented Jun 25, 2023 •
edited
Loading

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5627404

@thefrieddan1
Copy link
Contributor

@RFC1918-hub Please notice that some of the existing unit tests are failing after your changes.

@RFC1918-hub
Copy link
Contributor

@RFC1918-hub Please notice that some of the existing unit tests are failing after your changes.

Hi @thefrieddan1, I'm not too familiar with what the unit tests are.

Could it be cause of the incident name being different (taking the name instead of the type now for the XSOAR incident) to the mock incident that is it failing? Looking for rare_ssh_port but the incident name will now be "Rare SSH Port".

image

@thefrieddan1
Copy link
Contributor

@RFC1918-hub,
This is a partner supported pack.
We will inform the Partner and ask ExtraHop review and input on this.
As for the title / name. We might revert this change to comply with the existing unit test.

@thefrieddan1
Copy link
Contributor

Hi @RFC1918-hub,
I will continue with merging your branch.
But you need to sign the Contributor License Agreement.
Please sign it in:
Contributor License Agreement

@thefrieddan1 thefrieddan1 added the pending-contributor The PR is pending the response of its creator label Jun 27, 2023
@RFC1918-hub
Copy link
Contributor

@thefrieddan1 Thanks. I signed the Contributor License Agreement.

@thefrieddan1 thefrieddan1 merged commit 980ade9 into demisto:contrib/xsoar-contrib_RFC1918-hub-contrib-ExtraHop Jun 27, 2023
@content-bot content-bot mentioned this pull request Jun 27, 2023
Merged
3 tasks
thefrieddan1 added a commit that referenced this pull request Jun 27, 2023
@content-bot @xsoar-bot
@RFC1918-hub @thefrieddan1
[Marketplace Contribution] ExtraHop Reveal(x) - Content Pack Update (#…
5c0c764 
…27587) (#27760)

* "contribution update to pack "ExtraHop Reveal(x)""

* Update 2_2_0.md

* Fix flake8 line too long error.

* Revert type to title

* Update docker image.

* Revert marketplace changes to yml file.

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: RFC1918 <[email protected]>
Co-authored-by: Danny_Fried <[email protected]>
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
@content-bot @xsoar-bot
@RFC1918-hub @thefrieddan1 @MosheEichler
[Marketplace Contribution] ExtraHop Reveal(x) - Content Pack Update (#…
bfdbaa2 
…27587) (#27760)

* "contribution update to pack "ExtraHop Reveal(x)""

* Update 2_2_0.md

* Fix flake8 line too long error.

* Revert type to title

* Update docker image.

* Revert marketplace changes to yml file.

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: RFC1918 <[email protected]>
Co-authored-by: Danny_Fried <[email protected]>
xsoar-bot added a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
@content-bot @xsoar-bot
@RFC1918-hub @thefrieddan1
[Marketplace Contribution] ExtraHop Reveal(x) - Content Pack Update (d…
d43c635 
…emisto#27587) (demisto#27760)

* "contribution update to pack "ExtraHop Reveal(x)""

* Update 2_2_0.md

* Fix flake8 line too long error.

* Revert type to title

* Update docker image.

* Revert marketplace changes to yml file.

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: RFC1918 <[email protected]>
Co-authored-by: Danny_Fried <[email protected]>
@xsoar-bot xsoar-bot deleted the RFC1918-hub-contrib-ExtraHop branch November 23, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RFC1918-hub RFC1918-hub RFC1918-hub left review comments

@thefrieddan1 thefrieddan1 thefrieddan1 approved these changes

Assignees

@thefrieddan1 thefrieddan1

Labels
Contribution Thank you! Contributions are always welcome! docs-approved Partner Support Level Indicates that the contribution is for Partner supported pack Partner pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xsoar-bot @content-bot @CLAassistant @RFC1918-hub @thefrieddan1