GitHub actions poetry #27435
Merged
GitHub actions poetry #27435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorschw
reviewed
Jun 18, 2023
dorschw
reviewed
Jun 18, 2023
dorschw
reviewed
Jun 18, 2023
pyproject.toml
Outdated
| @@ -13,6 +13,7 @@ defusedxml = "^0.7.1" | |||
| demisto_sdk = "1.16.0" | |||
| requests = "^2.22.0" | |||
| pre-commit = "^2.20.0" | |||
| flake8 = "^4.0.1" | |||
There was a problem hiding this comment.
as we discussed in the meeting yesterday , we'll add it, if it cause something to fail, then we can take it out
There was a problem hiding this comment.
it will work on both cases, as flake8 is installed as a part of demisto-sdk.
I think we can add this as dependency to the content, as we use it in content as well (if we someday plan to remove flake8 from demisto-sdk, it still should remain on content.
There was a problem hiding this comment.
As none of the tasks here explicitly call flake8, please remove it.
dorschw
suggested changes
Jun 18, 2023
dorschw
suggested changes
Jun 19, 2023
pyproject.toml
Outdated
| @@ -13,6 +13,7 @@ defusedxml = "^0.7.1" | |||
| demisto_sdk = "1.16.0" | |||
| requests = "^2.22.0" | |||
| pre-commit = "^2.20.0" | |||
| flake8 = "^4.0.1" | |||
content-bot
changed the base branch from
master
to
contrib/demisto_github_actions_poetry
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @michal-dagan will know the proposed changes are ready to be reviewed. |
|
I've tested running all changed github actions:
@dorschw @DeanArbel FYI |
merit-maita
changed the base branch from
contrib/demisto_github_actions_poetry
to
master
dorschw
approved these changes
Jun 25, 2023
merit-maita
removed
the
Contribution
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* switched to poetry * added dependencies to toml * added --with ci flag * edit after validation failed * edit * added dateparser * locked the file * removed pipfile * returned files * edit yml * reverted changes * reverted changes * moved dateparser to dev * locked poetry * removed flake8 * edited poetry lock * edited poetry lock * fixed the action to run on this specific pr * fixed the action to run on this specific pr * edit * edit * edit * reverted changes to filled form and handle external pr * edited handle stale prs * edited handle stale prs again * edited handle stale prs with ci * check sync-contrib-base-branch, and revert stale branches * reverted the base branch, and check base branch on change * reverted the base branch, and check base branch on change * reverted the base branch, and check base branch on change * test close pr * test close pr
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* switched to poetry * added dependencies to toml * added --with ci flag * edit after validation failed * edit * added dateparser * locked the file * removed pipfile * returned files * edit yml * reverted changes * reverted changes * moved dateparser to dev * locked poetry * removed flake8 * edited poetry lock * edited poetry lock * fixed the action to run on this specific pr * fixed the action to run on this specific pr * edit * edit * edit * reverted changes to filled form and handle external pr * edited handle stale prs * edited handle stale prs again * edited handle stale prs with ci * check sync-contrib-base-branch, and revert stale branches * reverted the base branch, and check base branch on change * reverted the base branch, and check base branch on change * reverted the base branch, and check base branch on change * test close pr * test close pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6069
Description
Switched to poetry instead of pipenv in some github actions.