Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splunk py raise timezone exception #27316

Merged
merged 8 commits into from
Jun 12, 2023
Merged

Splunk py raise timezone exception #27316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f938e24
SplunkPy - fix uninformative error message when missing timezone in m…
darkushin Jun 8, 2023
6e189c3
Added RNs
darkushin Jun 8, 2023
35f3a7e
Merge branch 'master' of github.com:demisto/content into splunkPy_rai…
darkushin Jun 12, 2023
2b1046e
Updated readme
darkushin Jun 12, 2023
4e06a16
CR updates
darkushin Jun 12, 2023
0a18744
Update Packs/SplunkPy/ReleaseNotes/3_0_20.md
darkushin Jun 12, 2023
bb97a40
Updated Docker Image
darkushin Jun 12, 2023
0ef725a
Merge branch 'splunkPy_raise_timezone_exception' of github.com:demist…
darkushin Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packs/SplunkPy/Integrations/SplunkPy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ This integration was integrated and tested with Splunk v7.2.
| Use Splunk Clock Time For Fetch | | False |
| Parse Raw Part of Notable Events | | False |
| Replace with Underscore in Incident Fields | | False |
| Timezone of the Splunk server, in minutes. For example, if GMT is gmt +3, set timezone to +180. For UTC, set the timezone to 0. (Set only if the Splunk server is different than the Cortex XSOAR server.) Relevant only for fetching and mirroring notable events. | | False |
| Timezone of the Splunk server, in minutes. For example, if GMT is gmt +3, set timezone to +180. For UTC, set the timezone to 0. This is relevant only for fetching and mirroring notable events. It must be specified when mirroring is enabled. | | False |
| First fetch timestamp (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year) | The amount of time to go back when performing the first fetch, or when creating a mapping using the Select Schema option. | False |
| Extract Fields - CSV fields that will be parsed out of _raw notable events | | False |
| Event Type Field | Used only for mapping with the Select Schema option. The name of the field that contains the type of the event or alert. The default value is "source", which is a good option for notable events. However, you may choose any custom field. | False |
Expand Down
2 changes: 1 addition & 1 deletion Packs/SplunkPy/Integrations/SplunkPy/SplunkPy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ def get_last_update_in_splunk_time(last_update):

try:
splunk_timezone = int(params['timezone'])
except (KeyError, ValueError):
except (KeyError, ValueError, TypeError):
raise Exception('Cannot mirror incidents when timezone is not configured. Please enter the '
'timezone of the Splunk server being used in the integration configuration.')

Expand Down
4 changes: 2 additions & 2 deletions Packs/SplunkPy/Integrations/SplunkPy/SplunkPy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ configuration:
type: 8
section: Collect
advanced: true
- display: Timezone of the Splunk server, in minutes. For example, if GMT is gmt +3, set timezone to +180. For UTC, set the timezone to 0. (Set only if the Splunk server is different than the Cortex XSOAR server.) Relevant only for fetching and mirroring notable events.
- display: Timezone of the Splunk server, in minutes. For example, if GMT is gmt +3, set timezone to +180. For UTC, set the timezone to 0. This is relevant only for fetching and mirroring notable events. It must be specified when mirroring is enabled.
name: timezone
required: false
type: 0
Expand Down Expand Up @@ -626,7 +626,7 @@ script:
- contextPath: Splunk.UserMapping.SplunkUser
description: Splunk user mapping.
type: String
dockerimage: demisto/splunksdk-py3:1.0.0.61535
dockerimage: demisto/splunksdk-py3:1.0.0.62919
isfetch: true
ismappable: true
isremotesyncin: true
Expand Down
7 changes: 7 additions & 0 deletions Packs/SplunkPy/ReleaseNotes/3_0_20.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@

#### Integrations

##### SplunkPy

- Fixed an issue where it was possible to configure mirroring without specifying a timezone.
- Updated the Docker image to: *demisto/splunksdk-py3:1.0.0.62919*.
2 changes: 1 addition & 1 deletion Packs/SplunkPy/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Splunk",
"description": "Run queries on Splunk servers.",
"support": "xsoar",
"currentVersion": "3.0.19",
"currentVersion": "3.0.20",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down