Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores part 5 #27126

Merged
merged 16 commits into from
Jun 13, 2023
2 changes: 1 addition & 1 deletion Packs/IBMResilientSystems/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[file:IBMResilientSystems.yml]
ignore=IN126,IN145
ignore=IN126

[file:README.md]
ignore=RM106
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
ORG_NAME = DEMISTO_PARAMS['org']
USERNAME = DEMISTO_PARAMS.get('credentials', {}).get('identifier')
PASSWORD = DEMISTO_PARAMS.get('credentials', {}).get('password')
API_KEY_ID = DEMISTO_PARAMS.get('api_key_id')
API_KEY_SECRET = DEMISTO_PARAMS.get('api_key_secret')
API_KEY_ID = DEMISTO_PARAMS.get('credentials_api_key', {}).get('identifier') or DEMISTO_PARAMS.get('api_key_id')
API_KEY_SECRET = DEMISTO_PARAMS.get('credentials_api_key', {}).get('password') or DEMISTO_PARAMS.get('api_key_secret')
USE_SSL = not DEMISTO_PARAMS.get('insecure', False)
FETCH_TIME = DEMISTO_PARAMS.get('fetch_time', '')
TIME_FORMAT = '%Y-%m-%dT%H:%M:%SZ'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,18 @@ configuration:
name: api_key_id
required: false
type: 4
hidden: true
- display: API key secret
name: api_key_secret
required: false
type: 4
hidden: true
- display: API key ID
name: credentials_api_key
required: false
type: 9
displaypassword: API key secret
section: Connect
description: Case management that enables visibility across your tools for continual IR improvement.
display: IBM Resilient Systems
name: IBM Resilient Systems
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
urllib3
6 changes: 6 additions & 0 deletions Packs/IBMResilientSystems/ReleaseNotes/1_1_8.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### IBM Resilient Systems
Added the *API key ID* and *API key secret* integration parameters to support credentials fetching object.

2 changes: 1 addition & 1 deletion Packs/IBMResilientSystems/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "IBM Resilient Systems",
"description": "Case management that enables visibility across your tools for continual IR improvement",
"support": "xsoar",
"currentVersion": "1.1.7",
"currentVersion": "1.1.8",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
3 changes: 0 additions & 3 deletions Packs/Kenna/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[file:README.md]
ignore=RM104

[file:KennaV2.yml]
ignore=IN145
4 changes: 3 additions & 1 deletion Packs/Kenna/Integrations/KennaV2/KennaV2.py
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,9 @@ def delete_tags(client: Client, args: dict) -> Tuple[str, Dict[str, Any], List[D

def main():
params = demisto.params()
api = params.get('key')
api = params.get('credentials_key', {}).get('password') or params.get('key')
if not api:
raise DemistoException('Kenna API key must be provided.')
# Service base URL
base_url = params.get('url')
# Should we use SSL
Expand Down
10 changes: 8 additions & 2 deletions Packs/Kenna/Integrations/KennaV2/KennaV2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ configuration:
type: 0
- display: Kenna API key
name: key
required: true
required: false
type: 4
hidden: true
- displaypassword: Kenna API key
name: credentials_key
required: false
hiddenusername: true
type: 9
- defaultvalue: 'false'
display: Use system proxy settings
name: proxy
Expand Down Expand Up @@ -580,7 +586,7 @@ script:
- contextPath: Kenna.ConnectorRunsList.ReopenedVulnerabilities
description: Amount of re-opened vulnerabilities.
type: Number
dockerimage: demisto/python3:3.10.8.37233
dockerimage: demisto/python3:3.10.12.62631
feed: false
isfetch: false
longRunning: false
Expand Down
6 changes: 6 additions & 0 deletions Packs/Kenna/ReleaseNotes/1_1_17.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Kenna v2
- Added the *Kenna API key* integration parameters to support credentials fetching object.
- Updated the Docker image to: *demisto/python3:3.10.12.62631*.
2 changes: 1 addition & 1 deletion Packs/Kenna/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Kenna",
"description": "Use the Kenna v2 integration to search and update vulnerabilities, schedule a run connector, and manage tags and attributes.",
"support": "xsoar",
"currentVersion": "1.1.16",
"currentVersion": "1.1.17",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down