Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Tags v3 in Expanderv1 #27111

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@andrew-paloalto

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: EXPANDR-3996

Description

Expander users may have encountered errors when running the expanse-assign-tags-to-asset or expanse-assign-pocs-to-asset commands using the Network asset type.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

*added support for asset_type:
      - Network
      - Device
      - ResponsiveIP

---------

Co-authored-by: michal-dagan <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. post-demo Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels May 31, 2023
@content-bot content-bot requested a review from michal-dagan May 31, 2023 15:01
@michal-dagan michal-dagan requested a review from eyalpalo June 1, 2023 06:18
@eyalpalo eyalpalo added the ForceMerge Forcing the merge of the PR despite the build status label Jun 1, 2023
@eyalpalo
Copy link
Contributor

eyalpalo commented Jun 1, 2023

@dantavori need force merge due to test playbook failure. The failure is caused because some of the values expected from a command (not the one that changed in this PR) are missing. Will open another PR with a fix to the playbook.

@dantavori dantavori merged commit 0e53185 into master Jun 1, 2023
@dantavori dantavori deleted the contrib/andrew-paloalto_tags-v3 branch June 1, 2023 07:43
@michal-dagan michal-dagan mentioned this pull request Jun 1, 2023
11 tasks
DNRRomero pushed a commit to DNRRomero/xsoar that referenced this pull request Jun 6, 2023
* Support for Tags v3 in Expanderv1 (demisto#26998)

*added support for asset_type:
      - Network
      - Device
      - ResponsiveIP

---------

Co-authored-by: michal-dagan <[email protected]>

* added unitest

* fix

---------

Co-authored-by: Andrew Scott <[email protected]>
Co-authored-by: michal-dagan <[email protected]>
Co-authored-by: EyalPintzov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ForceMerge Forcing the merge of the PR despite the build status post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants