Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with handling null values. #27031

Merged
merged 26 commits into from
Jun 4, 2023
Merged

Fixed issues with handling null values. #27031

merged 26 commits into from
Jun 4, 2023

Conversation

spearmin10
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

FirstArrayElement/LastArrayElement doesn't return corect values for null value given to the argument.

Screenshots

https://paloaltonetworks.zoom.us/rec/share/UnCvyAzRTTxy1up6FrQbBzFhrUAVcOXcPTwS-5-9i5qznhc10ualRwgWskPKmfyI.ShVUNB2LGxlvxJdk
Passcode: Nv+idwGK7j

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels May 29, 2023
@content-bot content-bot changed the base branch from master to contrib/spearmin10_ArrayElement May 29, 2023 06:25
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @RotemAmit will know the proposed changes are ready to be reviewed.

@content-bot content-bot requested a review from RotemAmit May 29, 2023 06:25
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels May 29, 2023
Copy link
Contributor

@RotemAmit RotemAmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! Great job finding this issue and fixing it!
I just have a few notes on the release notes.

Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md Outdated Show resolved Hide resolved
Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md Outdated Show resolved Hide resolved
@RotemAmit RotemAmit requested review from ShirleyDenkberg and removed request for michalgold, idovandijk and GuyAfik May 31, 2023 14:17
@ShirleyDenkberg ShirleyDenkberg self-assigned this May 31, 2023
@ShirleyDenkberg
Copy link
Contributor

@RotemAmit Doc review completed.

@RotemAmit RotemAmit added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jun 4, 2023
@RotemAmit RotemAmit added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jun 4, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5441547

@RotemAmit RotemAmit merged commit 0691755 into demisto:contrib/spearmin10_ArrayElement Jun 4, 2023
RotemAmit added a commit that referenced this pull request Jun 4, 2023
* Fixed issues with handling null values. (#27031)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* update

* Updated docker tags

* Updated RN

* Added README

* Updated RN

* Update RN

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>

* fixed pre-commit error

---------

Co-authored-by: Masahiko Inoue <[email protected]>
Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
@spearmin10 spearmin10 deleted the ArrayElement branch June 5, 2023 05:27
maimorag pushed a commit that referenced this pull request Jun 6, 2023
* Fixed issues with handling null values. (#27031)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* update

* Updated docker tags

* Updated RN

* Added README

* Updated RN

* Update RN

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>

* fixed pre-commit error

---------

Co-authored-by: Masahiko Inoue <[email protected]>
Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
maimorag added a commit that referenced this pull request Jun 6, 2023
…t 6 (#27127)

* Align credentials stores for all Cortex Marketplace integrations- part 6

* adding Google BigQuery

* rl

* change require

* removing ignore

* cr

* required to false

* Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.py

Co-authored-by: Shelly Tzohar <[email protected]>

* Update ContentManagement Owner (#27171)

* St trustart to community (#27184)

* Changed pack support

* Added release notes for the support change

* update setup poetry version to 8 (#27185)

* Update Docker Image To demisto/py3-tools  (#27146)

* Updated Metadata Of Pack Active_Directory_Query

* Added release notes to pack Active_Directory_Query

* Packs/Active_Directory_Query/Integrations/Active_Directory_Query/Active_Directory_Query.yml Docker image update

* Updated Metadata Of Pack FeedAWS

* Added release notes to pack FeedAWS

* Packs/FeedAWS/Integrations/FeedAWS/FeedAWS.yml Docker image update

* Updated Metadata Of Pack Active_Directory_Query

* Updated Metadata Of Pack Active_Directory_Query

* Ews extension ps1 bug (#27153)

* Enables running the ews-message-trace-get  command without the sender_address and recipient_address arguments

* update RN

* comment correction

* Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning (#26699) (#27169)

* added validated files with new changes

* added validated files with new test cases

* added changes to simplify handling of 'null' in extraData and added 1_2_1.md  in releaseNotes

* added better assert statements to deal with key error, writer_creds is now a non mandatory param, mdx dependency version bumped dowm, added 1.2.0.md

* chore: revert non-package-related changes

* chore(release): v1.3.0 version bump

* feat: additional checks in assertions

* refactor(Devo_v2): remove unnecessary Pipfile

* fix(Devo_v2): revert `fetch_incidents_deduplication` parameter removal

Now it is set to hidden to avoid its future usage.

* fix(Devo_v2): revert `fetch_incidents_limit` parameter requirement

* fix(Devo_v2): revert `items_per_page` arguments to be optional again

Now the default value is "50" to avoid XSOAR terminating the command.

* fix(Devo_v2): restore `limit` argument from devo-multi-table-query command

* chore(Devo_v2): bump docker image version

* fix(Devo_v2): correct f-string interpolation

* fix(Devo_v2): correct validation errors for the `fetch_incidents_deduplication` parameter

* chore(Devo_v2,release): correct release notes and upcoming version

* docs(Devo_v2): remove mentions of "Deduplication parameters JSON" deprecated parameter

* fix(Devo_v2): revert to optional `items_per_page` default value in code



* fix(Devo_v2): correct errors surged after applying suggestions from PR

* fix(Devo_v2): correct .pack-ignore settings

* docs(style,Devo_v2): join lines



---------

Co-authored-by: Pável Kalmykov Razgovórov <[email protected]>
Co-authored-by: Abhijeet kumar <[email protected]>
Co-authored-by: Abhijeet <[email protected]>
Co-authored-by: michal-dagan <[email protected]>

* Citrix net scaler adc modeling rules (#27120)

* Updated the modeling rules to support more types of logs.

* Updated the parsing rule

* Updated the parsing rules to support more types of logs.

* Added release notes.

* Fixed issues with handling null values. (#27199)

* Fixed issues with handling null values. (#27031)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* update

* Updated docker tags

* Updated RN

* Added README

* Updated RN

* Update RN

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>

* fixed pre-commit error

---------

Co-authored-by: Masahiko Inoue <[email protected]>
Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: RotemAmit <[email protected]>

* Cisco catalyst addfield (#27102)

* update modeling rules

* update modeling rules

* update modeling rules

* update modeling rules

* update modeling rules

* update modeling rules

* update modeling rules

* update modeling rules

* Prisma cloud playbook fix (#27203)

* Task 26 - change AWSFQDN to NONAWSFQDN

* RN

* Prisma Access logout bug (#26700)

* Update .devcontainer.json name

* fix missing opening tag <multi-tenant>

* RN

* resolve conflict

* revert changes devcontainer.json

* version

* pre commit

* Update Packs/PrismaAccess/ReleaseNotes/2_0_4.md

Co-authored-by: yuvalbenshalom <[email protected]>

---------

Co-authored-by: gbouzar <[email protected]>
Co-authored-by: yuvalbenshalom <[email protected]>

* Prisma cloud playbook fix azure fqdn (#27206)

* Task 26 - change AzureFQDN to NONAzureFQDN

* RN

* PAN-OS tag vs tags bug (#27188)

* fix tag to tags in pan-os-list-rules command

* RN

* unskip DockerHardeningCheck in native ga (#27170)

* Update Docker Image To demisto/genericsql  (#27211)

* Updated Metadata Of Pack GenericSQL

* Added release notes to pack GenericSQL

* Packs/GenericSQL/Integrations/GenericSQL/GenericSQL.yml Docker image update

* Align credentials stores part 8 (#27200)

* align cred

* add ExceedLMS IAM

* Unskipp test playbook (#27193)

* unskip the TPB

* just fo test

* rollback test changes

* rollback test changes

* Ironscales Event Collector (#26496)

* first commit

* rns and other requirements

* major update

* added modeling rules - wip

* modeling rules changes

* some fixes

* Update IronscalesEventCollector_test.py

* Update IronscalesEventCollector.yml

* added modeling rules to rns

* auth fix

* Update IronscalesModelingRules.xif

* updates in collector

* precommit fix

* cleaner code

* better error handling

* demo fixes

* leftovers (except fetch_ids param)

* removed fetch_ids and more stuff

* Update IronscalesModelingRules.xif

* Apply suggestions from code review

Co-authored-by: Shahaf Ben Yakir <[email protected]>

* cr notes

* fixes

* Update Packs/IronscalesEventCollector/Integrations/IronscalesEventCollector/IronscalesEventCollector.py

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: Shahaf Ben Yakir <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>

* MOVEit Transfer vulnerability (#27209)

* new pack for cve-2023-34362

* fixes

* update RN

* update RN

* fixes

* fixes

* fixes

* secrets ignore

* typo in task 74

* revert changes to the MajorBreach pack

* update secrets ignore

* MacOS Mapping (#27064)

* Created a new MacOS pack

* Removed image.png

* Updated ModelingRules

* Update README.md

* Updated ModelingRules

* Updated README

* Update Packs/MacOS/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/MacOS/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/MacOS/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/MacOS/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update README.md

---------

Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: evisochek <[email protected]>

* GeneratePassword - JS to python (#27134)

* first commit

* second commit

* bump version

* update readme

* Update Packs/CommonScripts/ReleaseNotes/1_11_83.md

Co-authored-by: Shahaf Ben Yakir <[email protected]>

---------

Co-authored-by: Shahaf Ben Yakir <[email protected]>

* Update Docker Image To demisto/python3  (#27215)

* Updated Metadata Of Pack FeedSOCRadarThreatFeed

* Added release notes to pack FeedSOCRadarThreatFeed

* Packs/FeedSOCRadarThreatFeed/Integrations/FeedSOCRadarThreatFeed/FeedSOCRadarThreatFeed.yml Docker image update

* Updated Metadata Of Pack epo

* Added release notes to pack epo

* Packs/epo/Integrations/epoV2/epoV2.yml Docker image update

* Updated Metadata Of Pack CiscoStealthwatch

* Added release notes to pack CiscoStealthwatch

* Packs/CiscoStealthwatch/Integrations/CiscoStealthwatch/CiscoStealthwatch.yml Docker image update

* Updated Metadata Of Pack Securonix

* Added release notes to pack Securonix

* Packs/Securonix/Integrations/Securonix/Securonix.yml Docker image update

* Updated Metadata Of Pack NetBox

* Added release notes to pack NetBox

* Packs/NetBox/Integrations/NetBoxEventCollector/NetBoxEventCollector.yml Docker image update

* Updated Metadata Of Pack illuminate

* Added release notes to pack illuminate

* Packs/illuminate/Integrations/Analyst1/Analyst1.yml Docker image update

* Updated Metadata Of Pack BmcHelixRemedyForce

* Added release notes to pack BmcHelixRemedyForce

* Packs/BmcHelixRemedyForce/Integrations/BmcHelixRemedyForce/BmcHelixRemedyForce.yml Docker image update

* Updated Metadata Of Pack Rapid7_InsightIDR

* Added release notes to pack Rapid7_InsightIDR

* Packs/Rapid7_InsightIDR/Integrations/Rapid7_InsightIDR/Rapid7_InsightIDR.yml Docker image update

* Updated Metadata Of Pack Zerohack_XDR

* Added release notes to pack Zerohack_XDR

* Packs/Zerohack_XDR/Integrations/ZerohackXDR/ZerohackXDR.yml Docker image update

* Updated Metadata Of Pack XMCyber

* Added release notes to pack XMCyber

* Packs/XMCyber/Integrations/XMCyberIntegration/XMCyberIntegration.yml Docker image update

* Update Docker Image To demisto/pyjwt3  (#27217)

* Updated Metadata Of Pack Zoom

* Added release notes to pack Zoom

* Packs/Zoom/Integrations/Zoom/Zoom.yml Docker image update

* Packs/Zoom/Integrations/ZoomEventCollector/ZoomEventCollector.yml Docker image update

* Update Docker Image To demisto/btfl-soup  (#27219)

* Updated Metadata Of Pack Jira

* Added release notes to pack Jira

* Packs/Jira/Integrations/JiraV3/JiraV3.yml Docker image update

* Align credentials stores part 9 (#27201)

* Align credentials part 9

* add Telegram

* rl

* Update Packs/Telegram/Integrations/Telegram/Telegram.py

Co-authored-by: Shelly Tzohar <[email protected]>

---------

Co-authored-by: Shelly Tzohar <[email protected]>

* Update Docker Image To demisto/glpi  (#27220)

* Updated Metadata Of Pack GLPI

* Added release notes to pack GLPI

* Packs/GLPI/Integrations/GLPI/GLPI.yml Docker image update

* Update Docker Image To demisto/python3  (#27210)

* Updated Metadata Of Pack Base

* Added release notes to pack Base

* Packs/Base/Scripts/HighlightWords/HighlightWords.yml Docker image update

* Packs/Base/Scripts/GetIndicatorsByQuery/GetIndicatorsByQuery.yml Docker image update

* Packs/Base/Scripts/CheckDockerImageAvailable/CheckDockerImageAvailable.yml Docker image update

* Packs/Base/Scripts/GetIncidentsByQuery/GetIncidentsByQuery.yml Docker image update

* Packs/Base/Scripts/SearchIndicatorRelationships/SearchIndicatorRelationships.yml Docker image update

* Fixed validate and lint

---------

Co-authored-by: sberman <[email protected]>

* Update Docker Image To demisto/fastapi  (#27218)

* Updated Metadata Of Pack Jira

* Added release notes to pack Jira

* Packs/Jira/Integrations/JiraEventCollector/JiraEventCollector.yml Docker image update

* Bump pack from version Jira to 3.0.2.

---------

Co-authored-by: Content Bot <[email protected]>

* 1.15.5 (#27065)

* Rubrik release 1 2 2 (#26473) (#27223)

* Update .devcontainer.json name

* Rubrik Polaris Release 1.2.2

* Updated docker image tags

* resolving conflict

---------

Co-authored-by: Crest Data Systems <[email protected]>
Co-authored-by: crestdatasystems <[email protected]>
Co-authored-by: RotemAmit <[email protected]>

* Fix ExpanseV2 TPB (#27128)


* fixed tpb - removed the check for Domain.DomainStatus isNotEmpty

* Add search to open cti (#27189)

* added argument

* added rn

* argument name update

* Update Packs/OpenCTI/ReleaseNotes/1_0_7.md

Co-authored-by: Judah Schwartz <[email protected]>

* fixes

* fixes

* fixes

---------

Co-authored-by: Judah Schwartz <[email protected]>

* Update enabled key in filters and transformers yml (#27187)

* Update enabled key in script's yml

* Update docker images/release notes

* Add missing README files

* Bump pack from version FiltersAndTransformers to 1.2.20.

---------

Co-authored-by: Content Bot <[email protected]>

* Remove default values from yml - phase 1 (#27190)

* remove default values from yml - phase 1

* add err to ignore

* [TAXII2ApiModule] Fix kwargs argument in function call (#27205)

* Fix as_pages kwargs argument in function call

* Update RN to packs that using TAXII2ApiModule

* Change 'pack' to 'script' in release notes

* Apply suggestions from docs review

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: ShirleyDenkberg <[email protected]>

* CoreRestAPI URL suffix fix (#27227)

* fix issue

* update RN

---------

Co-authored-by: xsoar-bot <[email protected]>

* precommit fix MDX server (#27232)

* fix

---------

Co-authored-by: Shelly Tzohar <[email protected]>
Co-authored-by: Menachem Weinfeld <[email protected]>
Co-authored-by: Adi Daud <[email protected]>
Co-authored-by: content-bot <[email protected]>
Co-authored-by: israelpoli <[email protected]>
Co-authored-by: Pável Kalmykov Razgovórov <[email protected]>
Co-authored-by: Abhijeet kumar <[email protected]>
Co-authored-by: Abhijeet <[email protected]>
Co-authored-by: michal-dagan <[email protected]>
Co-authored-by: yasta5 <[email protected]>
Co-authored-by: Masahiko Inoue <[email protected]>
Co-authored-by: spearmin10 <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: guytamir10 <[email protected]>
Co-authored-by: Tomer Haimof <[email protected]>
Co-authored-by: rshunim <[email protected]>
Co-authored-by: gbouzar <[email protected]>
Co-authored-by: yuvalbenshalom <[email protected]>
Co-authored-by: Guy Afik <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
Co-authored-by: Shahaf Ben Yakir <[email protected]>
Co-authored-by: Ben Melamed <[email protected]>
Co-authored-by: eepstain <[email protected]>
Co-authored-by: evisochek <[email protected]>
Co-authored-by: sberman <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Co-authored-by: ilaner <[email protected]>
Co-authored-by: Crest Data Systems <[email protected]>
Co-authored-by: crestdatasystems <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
Co-authored-by: Judah Schwartz <[email protected]>
Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Dan Sterenson <[email protected]>
Co-authored-by: xsoar-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants