Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Google Vertex AI #27010

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@sepaprivate

Description

Fine-tuned to conduct natural conversation. Using Google Vertex Ai (PaLM API for Chat) The current integration of Google Vertex Ai is focusing only on the Generative AI model (PaLM) using the Chat prediction. Later, this plugin will be updated to include the following:

  • Model Creation
  • Model Fine Tuning
  • PaLM for Text

Notes

I will update the guide so you can test it as it will require a lot of steps to be configured

Auto-Generated Documentation Requiring Modification

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label May 27, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_sepaprivate-contrib-GoogleVertexAI May 27, 2023 02:10
I don't know how to add images to the readme so will look into it later
@content-bot content-bot requested a review from thefrieddan1 May 27, 2023 02:10
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @thefrieddan1 will very shortly look over your proposed changes.

@thefrieddan1 thefrieddan1 added Community Community Support Level Indicates that the contribution is for Community supported pack labels May 28, 2023
Copy link
Contributor

@thefrieddan1 thefrieddan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sepaprivate thank you for your contribution we appreciate your effort, I reviewed the content in the PR and would like to provide some feedback:

@thefrieddan1 thefrieddan1 added the pending-contributor The PR is pending the response of its creator label May 29, 2023
Changes as per pull request reviewer's feedback
@sepaprivate
Copy link
Contributor

All required changes have been applied. @thefrieddan1 thank you for your suggestions

remove print statement
Adding Images to readme
Fix Images paths
@sepaprivate
Copy link
Contributor

Readme is updated now with images

replace images with Doc_files
Fix yml structure
move doc_files to integration folder
Fix paths with new doc_files folder moved to integration folder
Fix Flake8 issues and replaced Demisto.log with Demisto.debug
Fix unused variable
Fixed Flake8 Errors
Change images paths and names
@thefrieddan1 thefrieddan1 added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. pending-demo Demo pending docs-approved and removed pending-contributor The PR is pending the response of its creator labels May 29, 2023
@thefrieddan1 thefrieddan1 added post-demo and removed pending-demo Demo pending labels May 30, 2023
Fixing Flake8 issues
@thefrieddan1 thefrieddan1 merged commit 0b7f77a into demisto:contrib/xsoar-contrib_sepaprivate-contrib-GoogleVertexAI May 30, 2023
thefrieddan1 pushed a commit that referenced this pull request May 30, 2023
* "pack contribution initial commit"

* Update README.md

I don't know how to add images to the readme so will look into it later

* Update README.md

* Update README.md

* Delete GoogleVertexAI_image.png

* Fix Logo

* Update pack_metadata.json

* Update GoogleVertexAI.yml

* Update GoogleVertexAI.py

* Update GoogleVertexAI.yml

* Update GoogleVertexAI.yml

* Update GoogleVertexAI.py

* Update GoogleVertexAI.py

* Update GoogleVertexAI.py

Changes as per pull request reviewer's feedback

* Update GoogleVertexAI.py

remove print statement

* Update README.md

Adding Images to readme

* Update README.md

Fix Images paths

* Add Images folder for readme

* Delete Packs/GoogleVertexAI/images directory

* Add files via upload

* Update README.md

replace images with Doc_files

* Update GoogleVertexAI.yml

Fix yml structure

* Delete Packs/GoogleVertexAI/Doc_files directory

move doc_files to integration folder

* Move Doc_files to integration folder

* Update README.md

Fix paths with new doc_files folder moved to integration folder

* Update GoogleVertexAI.py

Fix Flake8 issues and replaced Demisto.log with Demisto.debug

* Update GoogleVertexAI.py

Fix unused variable

* Update GoogleVertexAI.py

Fixed Flake8 Errors

* Update GoogleVertexAI.py

* Update README.md

Change images paths and names

* Delete Packs/GoogleVertexAI/Integrations/GoogleVertexAI/Doc_files directory

No need for that folder anymore

* Update GoogleVertexAI.py

Fix test_module

* Update GoogleVertexAI.py

* Update GoogleVertexAI.py

Fixing Flake8 issues

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: sepaprivate <[email protected]>
@xsoar-bot xsoar-bot deleted the sepaprivate-contrib-GoogleVertexAI branch November 23, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Community Contribution Thank you! Contributions are always welcome! docs-approved post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants