Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rapid7 InsightVM] Fix token Parameter BC Issue #26982

Merged
merged 7 commits into from
May 29, 2023

Conversation

MichaelYochpaz
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fix token parameter having unexpected values in some cases (string instead of dict, and empty string instead of None) after upgrading to 1.2.0+ and using a previous instance.

@MichaelYochpaz MichaelYochpaz requested a review from bziser May 24, 2023 12:49
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Packs/Rapid7_Nexpose/ReleaseNotes/1_2_9.md Outdated Show resolved Hide resolved
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Rapid7_Nexpose pack version was bumped to 1.2.10.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@MichaelYochpaz MichaelYochpaz requested a review from bziser May 28, 2023 06:42
@MichaelYochpaz MichaelYochpaz force-pushed the insightvm-fix-token-field branch from f11303b to fbf1a60 Compare May 28, 2023 06:48
@MichaelYochpaz MichaelYochpaz requested a review from bziser May 29, 2023 14:48
@bziser bziser merged commit 1740d1e into master May 29, 2023
@bziser bziser deleted the insightvm-fix-token-field branch May 29, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants