Modify RF Playbooks: Check for "Recorded Future v2" instead of "Recorded Future" integration instance #26589
Conversation
content-bot
changed the base branch from
master
to
contrib/randomizerxd_randomizerxd-Recorded-Future-Playbooks
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @thefrieddan1 will know the proposed changes are ready to be reviewed. |
|
Hi @randomizerxd , Thanks |
content-bot
added
Community
Contribution Form Filled
|
Sorry I thought I had already filled it out. I just completed it. |
…ooks' into randomizerxd-Recorded-Future-Playbooks
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
playbook currently fails when no RF results are returned
…ooks' into randomizerxd-Recorded-Future-Playbooks
thefrieddan1
added
Community
Partner Support Level
|
Hi @randomizerxd, Thanks for filling the Contribution Registration. |
thefrieddan1
added
the
pending-contributor
|
I have already updated the version and release notes. I manually created 1_5_3.md and updated currentVersion to 1.5.3. |
|
@randomizerxd verion 1.5.3 is already in master, |
|
@randomizerxd Thank you for your time and effort in making this contribution. I have reviewed your changes and I must say, you've done an excellent job! There is just one thing I noticed that I would like to bring up with you. In the playbooks |
|
Thanks Erez (@efelmandar)! Sure. From my understanding, the |
|
@randomizerxd Following our conversation I approve the PR - @thefrieddan1 FYI |
thefrieddan1
added
ready-for-instance-test
thefrieddan1
merged commit f97aca5
into
demisto:contrib/randomizerxd_randomizerxd-Recorded-Future-Playbooks
…ded Future" integration instance (#26589) (#27020) * Update playbook-Recorded_Future_CVE_Reputation.yml * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Check for "Recorded Future v2" instead of "Recorded Future" integration instance * Create 1_5_3.md * update currentVersion to 1.5.3 * scriptarguments inputs.url not needed * scriptarguments inputs.url not needed * ${inputs.URL} instead of ${RecordedFuture.URL.name} playbook currently fails when no RF results are returned * ${inputs.URL} instead of ${RecordedFuture.URL.name} playbook currently fails when no RF results are returned * ${inputs.CVE} instead of ${RecordedFuture.CVE.name} playbook currently fails when no RF results are returned * ${inputs.CVE} instead of ${RecordedFuture.CVE.name} playbook currently fails when no RF results are returned * ${inputs.Domain} instead of ${RecordedFuture.Domain.name} playbook currently fails when no RF results are returned * ${inputs.Domain} instead of ${RecordedFuture.Domain.name} playbook currently fails when no RF results are returned * ${inputs.IP} instead of ${RecordedFuture.IP.name} playbook currently fails when no RF results are returned * ${inputs.IP} instead of ${RecordedFuture.IP.name} playbook currently fails when no RF results are returned * Bump version --------- Co-authored-by: Randy Baldwin <[email protected]> Co-authored-by: Danny_Fried <[email protected]>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have