Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - Expander - Update Cortex ASM - Service Ownership playbook #26442

Merged
merged 2 commits into from
May 11, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@BigEasyJ

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - Reviewing with @kball-pa

Related Issues

fixes: EXPANDR-3830 to address #25927

Description

  • Remove the service owner field change related to service accounts in GCP enrichment playbook.
  • Remove the service accounts look up in Service Ownership playbook.
  • Fix an issue where GCP project is not found.
  • Update the Cortex ASM - Service Ownership playbook to check for GCP as an external service before completing GCP related tasks for ranking users.

Screenshots

Cortex_ASM_-_Service_Ownership_updated_Fri_May_05_2023

Cortex_ASM_-_GCP_Enrichment_ACES-2371_Fri_May_05_2023

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

…6334)

* Update Cortex ASM - Service Ownership playbook

- Fixed an issue where GCP project is not found.
- Updated the Cortex ASM - Service Ownership playbook to check for GCP as an external service before completing GCP related tasks for ranking users.

* Remove unneccessary condition from playbook

- Local validate did not catch input that was not defined, but CI/CD validate did
- Removing unused conditional check in "What provider is this service?" task #14

* Update Service Ownership and GCP Enrichment playbooks

- Remove Service Account lookup and source updates from Cortex_ASM_-_GCP_Enrichment playbook.
- Remove retrieval of owners assocaited to a service account until more testing is completed.

* Update release notes

* Updates from code review

* Update PNG
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community labels May 10, 2023
@content-bot content-bot requested a review from GuyAfik May 10, 2023 18:06
@GuyAfik GuyAfik merged commit 5fedf28 into master May 11, 2023
@GuyAfik GuyAfik deleted the contrib/BigEasyJ_EXPANDR-3830_service_owner_playbook branch May 11, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants