-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix feed unit42 intel object #24636
Merged
Merged
Fix feed unit42 intel object #24636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantavori
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, please resolve here the notes as the other PR's review
AradCarmi
commented
Feb 16, 2023
…t into fix_FeedUnit42IntelObject
Link to the unit tests coverage report: |
ayman-m
pushed a commit
to my-soar/content
that referenced
this pull request
Feb 24, 2023
* Added validation for the create time in publication * Added UT * updated release notes * Updated docker image * Update Packs/Unit42Intel/ReleaseNotes/1_0_5.md * Updated docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
relates: link to the issue
Description
Fixed an issue where the fetch-indicators command fails parsing created field correctly.
Screenshots
Paste here any images that will help the reviewer