Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for update_core_packs_list for all MPs #24154

Merged
merged 9 commits into from
Feb 16, 2023

Conversation

ShahafBenYakir
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir commented Jan 29, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CRTX-73707

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ShahafBenYakir
Copy link
Contributor Author

This is still a draft, will add a test after will get approval on the packs list.

@ShahafBenYakir ShahafBenYakir marked this pull request as ready for review February 9, 2023 11:10
@ShahafBenYakir ShahafBenYakir requested review from dantavori and removed request for a team, bakatzir and GuyLibermanPA February 9, 2023 11:10
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be merged after the next SDK release with the corresponding changes there

@dantavori dantavori added the ForceMerge Forcing the merge of the PR despite the build status label Feb 16, 2023
@dantavori
Copy link
Contributor

build failures:

  1. BA115 fails on removing a file which is no longer used.
  2. mpv2 run tests fails on a known issue.

@dantavori dantavori merged commit 8b9ac86 into master Feb 16, 2023
@dantavori dantavori deleted the core_packs_logic_update branch February 16, 2023 20:55
ayman-m pushed a commit to my-soar/content that referenced this pull request Feb 24, 2023
* Added support for update_core_packs_list for all MPs

* fixes

---------

Co-authored-by: tkatzir <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants